From patchwork Wed Jan 14 23:47:45 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matt Carlson X-Patchwork-Id: 18558 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 7AC96DE0DC for ; Thu, 15 Jan 2009 10:48:27 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757457AbZANXsW (ORCPT ); Wed, 14 Jan 2009 18:48:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757426AbZANXsW (ORCPT ); Wed, 14 Jan 2009 18:48:22 -0500 Received: from mms2.broadcom.com ([216.31.210.18]:4203 "EHLO mms2.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757335AbZANXsU (ORCPT ); Wed, 14 Jan 2009 18:48:20 -0500 Received: from [10.11.16.99] by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.3.2)); Wed, 14 Jan 2009 15:47:46 -0800 X-Server-Uuid: D3C04415-6FA8-4F2C-93C1-920E106A2031 Received: by mail-irva-10.broadcom.com (Postfix, from userid 47) id F344B2C1; Wed, 14 Jan 2009 15:47:46 -0800 (PST) Received: from mail-irva-8.broadcom.com (mail-irva-8 [10.11.18.52]) by mail-irva-10.broadcom.com (Postfix) with ESMTP id DE9EE2B0; Wed, 14 Jan 2009 15:47:46 -0800 (PST) Received: from mail-irva-13.broadcom.com (mail-irva-13.broadcom.com [10.11.16.103]) by mail-irva-8.broadcom.com (MOS 3.7.5a-GA) with ESMTP id HKZ53462; Wed, 14 Jan 2009 15:47:45 -0800 (PST) Received: from xw6200 (mcarlson [10.12.148.101]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id A3BD174D03; Wed, 14 Jan 2009 15:47:45 -0800 (PST) Date: Wed, 14 Jan 2009 15:47:45 -0800 From: "Matt Carlson" To: "Ben Greear" cc: NetDev Subject: Re: Bad tg3 performance on S10 netbook Message-ID: <20090114234745.GA23993@xw6200.broadcom.net> References: <496E64BB.7080709@candelatech.com> MIME-Version: 1.0 In-Reply-To: <496E64BB.7080709@candelatech.com> User-Agent: Mutt/1.5.16 (2007-06-09) X-WSS-ID: 6570A6283FC37897602-01-01 Content-Disposition: inline Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 14, 2009 at 02:18:35PM -0800, Ben Greear wrote: > We are testing an S10 netbook from Lenovo and it's built-in > tg3 NIC is getting lots of 'rx-irq-missed' events and is dropping > packets while running at about 45Mbps tx + rx. > This is kernel 2.6.25 plus some hacks. We did most testing > on the stock 2.6.25 tg3 driver, but a quick attempt at using > the latest tg3 from bcm's site shows the same irq-miss issue. > > We tried forcing the cpufreq to max (1.6Ghz) and that didn't > help much. > > We tried setting the rx buffers to 511 (max for this chip it seems) > and that didn't help. > > The one thing that *does* help is to run something that eats a lot > of CPU. This is what made us think that the cpufreq was the issue, > but again, hard-coding it didn't help. > > We tried turning on adaptive-rx (it is off by default), and again, > no improvement. > > So, does anyone have any suggestions on what else to poke at? > > Full lspci output is below. > > Thanks, > Ben Does the following patch fix the problem? --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- 1/drivers/net/tg3.c 2008-11-10 10:50:34.000000000 -0800 +++ 2/drivers/net/tg3.c 2009-01-14 08:28:10.000000000 -0800 @@ -10709,7 +10709,7 @@ static void __devinit tg3_get_eeprom_hw_ tp->tg3_flags2 |= TG3_FLG2_IS_NIC; } val = tr32(VCPU_CFGSHDW); - if (val & VCPU_CFGSHDW_ASPM_DBNC) + /* if (val & VCPU_CFGSHDW_ASPM_DBNC) */ tp->tg3_flags |= TG3_FLAG_ASPM_WORKAROUND; if ((val & VCPU_CFGSHDW_WOL_ENABLE) && (val & VCPU_CFGSHDW_WOL_MAGPKT))