From patchwork Fri Sep 21 02:52:55 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Janis Johnson X-Patchwork-Id: 185556 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 21AED2C008B for ; Fri, 21 Sep 2012 12:53:28 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1348800809; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Message-ID:Date:From:Reply-To:User-Agent:MIME-Version: To:Subject:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=TlHjwZdzH+mVmYap5WXgEGDl9CU=; b=qStm3E2iGAWZyo3 9NOyd0lYxnZLwdvjcKgWHPHt6elI3TMV4XfStB2/XCjYuvGbEJXsePxcZDi+Hz3O 20TkCBbvXHV7xlkJ6Q7xxsCAWJCvxbeM1RnqgBFqQgZmna26tI7UhvBEPnAeSjaa SZkOMc85rMqEGL1uAdyOCKZ1ZR74= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Message-ID:Date:From:Reply-To:User-Agent:MIME-Version:To:Subject:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=KSzMXjp/6Zx4xJDmdfkO8ux+quYosOwOqvJKBVFhGiAqa75dwKB/cdZWfHLQxb hrCA1oy82X+kd8l0gpLPWt8Eq6Et+jqlK0HMgD5yemeHZ0PizvxZn8misdLvw6/y 0HvpdPFAzS9yPd5nXHDDO1Xj9c1VKvontsox1TYl+seKg=; Received: (qmail 2376 invoked by alias); 21 Sep 2012 02:53:24 -0000 Received: (qmail 2365 invoked by uid 22791); 21 Sep 2012 02:53:24 -0000 X-SWARE-Spam-Status: No, hits=-3.7 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_HOSTKARMA_W, RCVD_IN_HOSTKARMA_WL, TW_VF X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 Sep 2012 02:53:11 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TEtMc-0001zD-Vg from Janis_Johnson@mentor.com for gcc-patches@gcc.gnu.org; Thu, 20 Sep 2012 19:53:11 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 20 Sep 2012 19:53:10 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.1.289.1; Thu, 20 Sep 2012 19:53:10 -0700 Message-ID: <505BD687.3030408@mentor.com> Date: Thu, 20 Sep 2012 19:52:55 -0700 From: Janis Johnson Reply-To: User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.28) Gecko/20120313 Thunderbird/3.1.20 MIME-Version: 1.0 To: "gcc-patches@gcc.gnu.org" Subject: [testsuite] fix to check_effective_target_arm_hard_vfp_ok Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Tests in gcc.target/arm/aapcs check for floating-point arguments being passed correctly, but the added flag "-mfloat-abi=hard" can be overridden by another value in flags used for all tests (like multilib flags), causing the tests to fail. The tests in that directory are all gated on effective-target arm_hard_vfp_ok; this patch changes its code to return 0 if the test will use a different value of -mfloat-abi. Tested on arm-none-eabi with a variety of test flags. I'm hoping to hear from ARM experts that this is OK; there are a handful of tests in arm/aapcs that pass even with -mfloat-abi=softfp, so a better solution might be to skip individual tests for that option. Janis 2012-09-20 Janis Johnson * lib/target-supports.exp (check_effective_target_arm_hard_vfp_ok): Return 0 if already specifying -mfloat-abi other than hard. Index: lib/target-supports.exp =================================================================== --- lib/target-supports.exp (revision 191501) +++ lib/target-supports.exp (working copy) @@ -2053,7 +2053,8 @@ # options. proc check_effective_target_arm_hard_vfp_ok { } { - if { [check_effective_target_arm32] } { + if { [check_effective_target_arm32] + && ! [check-flags [list "" { *-*-* } { "-mfloat-abi=*" } { "-mfloat-abi=hard" }]] } { return [check_no_compiler_messages arm_hard_vfp_ok executable { int main() { return 0;} } "-mfpu=vfp -mfloat-abi=hard"]