Patchwork [07/10] pulseaudio: remove dependency on gettext

login
register
mail settings
Submitter Arnout Vandecappelle
Date Sept. 21, 2012, 12:54 a.m.
Message ID <20120921005422.11838.41552.stgit@localhost>
Download mbox | patch
Permalink /patch/185536/
State Superseded
Headers show

Comments

Arnout Vandecappelle - Sept. 21, 2012, 12:54 a.m.
From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

The dependency on gettext is only due to libglib2, not due to
portaudio itself.  It works fine without gettext if libglib2 is
not selected.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/multimedia/pulseaudio/Config.in     |    2 +-
 package/multimedia/pulseaudio/pulseaudio.mk |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Thomas Petazzoni - Sept. 21, 2012, 7:30 a.m.
Dear Arnout Vandecappelle \(Essensium/Mind\),

On Fri, 21 Sep 2012 02:54:22 +0200, Arnout Vandecappelle
\(Essensium/Mind\) wrote:
> From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> 
> The dependency on gettext is only due to libglib2, not due to
> portaudio itself.  It works fine without gettext if libglib2 is
> not selected.

This description doesn't match what the patch is doing. The description
says that you remove the gettext dependency, but the patch only changes
the dependency to a _IF_LOCALE dependency.

Thomas

Patch

diff --git a/package/multimedia/pulseaudio/Config.in b/package/multimedia/pulseaudio/Config.in
index 6c767bb..4845ffa 100644
--- a/package/multimedia/pulseaudio/Config.in
+++ b/package/multimedia/pulseaudio/Config.in
@@ -5,7 +5,7 @@  config BR2_PACKAGE_PULSEAUDIO
 	select BR2_PACKAGE_JSON_C
 	select BR2_PACKAGE_LIBSNDFILE
 	select BR2_PACKAGE_SPEEX
-	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
+	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
 	help
 	  PulseAudio is a sound system for POSIX OSes, meaning that it
 	  is a proxy for your sound applications. It allows you to do
diff --git a/package/multimedia/pulseaudio/pulseaudio.mk b/package/multimedia/pulseaudio/pulseaudio.mk
index 406dd8f..8015070 100644
--- a/package/multimedia/pulseaudio/pulseaudio.mk
+++ b/package/multimedia/pulseaudio/pulseaudio.mk
@@ -16,7 +16,7 @@  PULSEAUDIO_CONF_OPT = \
 
 PULSEAUDIO_DEPENDENCIES = \
 	host-pkg-config libtool json-c libsndfile speex host-intltool \
-	$(if $(BR2_NEEDS_GETTEXT),gettext) \
+	$(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext) \
 	$(if $(BR2_PACKAGE_LIBATOMIC_OPS),libatomic_ops) \
 	$(if $(BR2_PACKAGE_LIBSAMPLERATE),libsamplerate) \
 	$(if $(BR2_PACKAGE_ALSA_LIB),alsa-lib) \