Patchwork gettext: don't build tools if they won't be installed

login
register
mail settings
Submitter Arnout Vandecappelle
Date Sept. 20, 2012, 10:42 p.m.
Message ID <1348180978-20654-1-git-send-email-arnout@mind.be>
Download mbox | patch
Permalink /patch/185519/
State Superseded
Headers show

Comments

Arnout Vandecappelle - Sept. 20, 2012, 10:42 p.m.
When only libintl is requested from gettext, it is not necessary to
build and install the tools in staging.  Just run configure and make
in the gettext-runtime directory.

This _will_ install the gettext executable in the target.  But that
seems the correct thing to do, since it may be used by scripts.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

---
 package/gettext/gettext.mk |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
Thomas Petazzoni - Sept. 21, 2012, 7:13 a.m.
Dear Arnout Vandecappelle (Essensium/Mind),

On Fri, 21 Sep 2012 00:42:58 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:

> When only libintl is requested from gettext, it is not necessary to
> build and install the tools in staging.  Just run configure and make
> in the gettext-runtime directory.
> 
> This _will_ install the gettext executable in the target.  But that
> seems the correct thing to do, since it may be used by scripts.

Which scripts?

Thomas
Gustavo Zacarias - Sept. 21, 2012, 10:47 a.m.
On 09/20/12 19:42, Arnout Vandecappelle (Essensium/Mind) wrote:

> When only libintl is requested from gettext, it is not necessary to
> build and install the tools in staging.  Just run configure and make
> in the gettext-runtime directory.
> 
> This _will_ install the gettext executable in the target.  But that
> seems the correct thing to do, since it may be used by scripts.

It wasn't installed before and things worked, why would it be needed now?
Regards.

Patch

diff --git a/package/gettext/gettext.mk b/package/gettext/gettext.mk
index 74f5218..1ddd98c 100644
--- a/package/gettext/gettext.mk
+++ b/package/gettext/gettext.mk
@@ -31,9 +31,7 @@  endif
 # When the gettext tools are not enabled in the configuration, we only
 # install libintl to the target.
 ifeq ($(BR2_PACKAGE_GETTEXT_TOOLS),)
-define GETTEXT_INSTALL_TARGET_CMDS
-	cp -dpf $(STAGING_DIR)/usr/lib/libintl*.so* $(TARGET_DIR)/usr/lib/
-endef
+GETTEXT_SUBDIR = gettext-runtime
 endif # GETTEXT_TOOLS = n
 
 $(eval $(autotools-package))