mbox

[U-Boot,PULL] u-boot-usb/master

Message ID 201209210005.55282.marex@denx.de
State Accepted
Delegated to: Tom Rini
Headers show

Pull-request

git://git.denx.de/u-boot-usb.git master

Message

Marek Vasut Sept. 20, 2012, 10:05 p.m. UTC
The following changes since commit 5fb29f3c48d26981b117b08286bc16ec99d4ca0b:

  Merge branch 'ext4' (2012-09-20 11:27:35 -0700)

are available in the git repository at:


  git://git.denx.de/u-boot-usb.git master

for you to fetch changes up to 93ad908c43ed5d8e3e546dd22fa08b668c5090d9:

  usb: do explicit unaligned accesses (2012-09-21 00:05:00 +0200)

----------------------------------------------------------------
Lucas Stach (1):
      usb: do explicit unaligned accesses

Ɓukasz Majewski (2):
      dfu:usb: Support for ext4
      dfu:usb:fix: Read the "filesize" environment variable only when file read

 common/usb_hub.c            |   14 +++++++++-----
 drivers/dfu/dfu_mmc.c       |   34 +++++++++++++++++++++++++++-------
 drivers/usb/host/ehci-hcd.c |    7 +++++--
 3 files changed, 41 insertions(+), 14 deletions(-)

Comments

Tom Rini Sept. 21, 2012, 5:59 p.m. UTC | #1
On Fri, Sep 21, 2012 at 12:05:55AM +0200, Marek Vasut wrote:

> The following changes since commit 5fb29f3c48d26981b117b08286bc16ec99d4ca0b:
> 
>   Merge branch 'ext4' (2012-09-20 11:27:35 -0700)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to 93ad908c43ed5d8e3e546dd22fa08b668c5090d9:
> 
>   usb: do explicit unaligned accesses (2012-09-21 00:05:00 +0200)
> 
> ----------------------------------------------------------------
> Lucas Stach (1):
>       usb: do explicit unaligned accesses
> 
> ??ukasz Majewski (2):
>       dfu:usb: Support for ext4
>       dfu:usb:fix: Read the "filesize" environment variable only when file read
> 
>  common/usb_hub.c            |   14 +++++++++-----
>  drivers/dfu/dfu_mmc.c       |   34 +++++++++++++++++++++++++++-------
>  drivers/usb/host/ehci-hcd.c |    7 +++++--
>  3 files changed, 41 insertions(+), 14 deletions(-)

I've applied this.  But please note:
Testing edminiv2 on -00600-g50d924b
Fri Sep 21 10:57:25 MST 2012
Configuring for edminiv2 board...
   text    data     bss     dec     hex filename
 195013    3536   86692  285241   45a39 edminiv2/u-boot
ehci-hcd.c: In function 'ehci_submit_async':
ehci-hcd.c:291:2: warning: #warning CONFIG_SYS_MALLOC_LEN may be too small for EHCI [-Wcpp]

--------------------- SUMMARY ----------------------------
Boards compiled: 1
Boards with warnings but no errors: 1 ( edminiv2 )
----------------------------------------------------------

Albert, this is your platform.
Marek Vasut Sept. 21, 2012, 6:05 p.m. UTC | #2
Dear Tom Rini,

> On Fri, Sep 21, 2012 at 12:05:55AM +0200, Marek Vasut wrote:
> > The following changes since commit 5fb29f3c48d26981b117b08286bc16ec99d4ca0b:
> >   Merge branch 'ext4' (2012-09-20 11:27:35 -0700)
> > 
> > are available in the git repository at:
> >   git://git.denx.de/u-boot-usb.git master
> > 
> > for you to fetch changes up to 93ad908c43ed5d8e3e546dd22fa08b668c5090d9:
> >   usb: do explicit unaligned accesses (2012-09-21 00:05:00 +0200)
> > 
> > ----------------------------------------------------------------
> > 
> > Lucas Stach (1):
> >       usb: do explicit unaligned accesses
> > 
> > ??ukasz Majewski (2):
> >       dfu:usb: Support for ext4
> >       dfu:usb:fix: Read the "filesize" environment variable only when
> >       file read
> >  
> >  common/usb_hub.c            |   14 +++++++++-----
> >  drivers/dfu/dfu_mmc.c       |   34 +++++++++++++++++++++++++++-------
> >  drivers/usb/host/ehci-hcd.c |    7 +++++--
> >  3 files changed, 41 insertions(+), 14 deletions(-)
> 
> I've applied this.  But please note:
> Testing edminiv2 on -00600-g50d924b
> Fri Sep 21 10:57:25 MST 2012
> Configuring for edminiv2 board...
>    text    data     bss     dec     hex filename
>  195013    3536   86692  285241   45a39 edminiv2/u-boot
> ehci-hcd.c: In function 'ehci_submit_async':
> ehci-hcd.c:291:2: warning: #warning CONFIG_SYS_MALLOC_LEN may be too small
> for EHCI [-Wcpp]
> 
> --------------------- SUMMARY ----------------------------
> Boards compiled: 1
> Boards with warnings but no errors: 1 ( edminiv2 )
> ----------------------------------------------------------
> 
> Albert, this is your platform.

Did this explode only now? This warning was added a while ago.

Best regards,
Marek Vasut
Tom Rini Sept. 21, 2012, 6:13 p.m. UTC | #3
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/21/12 11:05, Marek Vasut wrote:
> Dear Tom Rini,
> 
>> On Fri, Sep 21, 2012 at 12:05:55AM +0200, Marek Vasut wrote:
>>> The following changes since commit 
>>> 5fb29f3c48d26981b117b08286bc16ec99d4ca0b: Merge branch 'ext4' 
>>> (2012-09-20 11:27:35 -0700)
>>> 
>>> are available in the git repository at: 
>>> git://git.denx.de/u-boot-usb.git master
>>> 
>>> for you to fetch changes up to 
>>> 93ad908c43ed5d8e3e546dd22fa08b668c5090d9: usb: do explicit 
>>> unaligned accesses (2012-09-21 00:05:00 +0200)
>>> 
>>> ----------------------------------------------------------------
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> 
Lucas Stach (1):
>>> usb: do explicit unaligned accesses
>>> 
>>> ??ukasz Majewski (2): dfu:usb: Support for ext4 dfu:usb:fix: 
>>> Read the "filesize" environment variable only when file read
>>> 
>>> common/usb_hub.c            |   14 +++++++++----- 
>>> drivers/dfu/dfu_mmc.c       |   34 
>>> +++++++++++++++++++++++++++------- drivers/usb/host/ehci-hcd.c 
>>> |    7 +++++-- 3 files changed, 41 insertions(+), 14 
>>> deletions(-)
>> 
>> I've applied this.  But please note: Testing edminiv2 on 
>> -00600-g50d924b Fri Sep 21 10:57:25 MST 2012 Configuring for 
>> edminiv2 board... text    data     bss     dec     hex filename 
>> 195013    3536   86692  285241   45a39 edminiv2/u-boot 
>> ehci-hcd.c: In function 'ehci_submit_async': ehci-hcd.c:291:2: 
>> warning: #warning CONFIG_SYS_MALLOC_LEN may be too small for
>> EHCI [-Wcpp]
>> 
>> --------------------- SUMMARY ----------------------------
>> Boards compiled: 1 Boards with warnings but no errors: 1 (
>> edminiv2 ) 
>> ----------------------------------------------------------
>> 
>> Albert, this is your platform.
> 
> Did this explode only now? This warning was added a while ago.

Yes, it's one of the differences in my logs before and after.

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iQIcBAEBAgAGBQJQXK5eAAoJENk4IS6UOR1WX0UP/AxJfosIF/EXmQrOadNe4ZEL
tpEVmYKnjA30DH2apC0xyoHMDdnSRJ/zsmsyg7/QypiB0det2kTkrzPHsmwUmKGs
c0xnETPTj/uKRYwJSi8mbhmtIMkTdHA3q4dp6VQRMmUpCEr2CdrVOl8pIt1C6g0h
qoRSsbGdhbhN7f1PpeAOzvxbRebBPx+ImGMP9dfjYCy2rMaEDQjukXVlVRFtZtTF
QfWki6kEPa5P5Km+ccK1CKJ6GHeP/cbwstyId6XmKoDWfCEY5ZkljxKrYb64xPnd
vofWsX0Ji2qkLbYsJMv+K2j5QVl+4y6NDlI/5ftkZOAXL9m5E8EBccwUSSsiOXe9
7Zl3xTFeld12JqJpZC77o9zYBuc6Or3wS0pirPy3XtC2mJsLH/jSx50F6cjrMVX2
X407rZ9yBtogZErM298vd4VZqaN2IbMYqBiY747QJ1w94hui89Ls7MYBibA8mdsN
DBL5zWQC8uBERmedAVp2lTIAF6EQ4AluDK6yO4zva1OMa3RRmY0g3fMCEXCsDlDi
S90LMHk88pdzzMM7wJB7k3twd4o+GDIAUNkIW4Eho+fXtegMR+FTvyiYKPrrelNB
qf46ZTgGOtRjcX76jajRjU2Nuy4pI33AWjETLf1ZBlFQ5OPr2IyV5taj/z5cwYw3
BMC18TaPL9nlL4KPmP6+
=Zz98
-----END PGP SIGNATURE-----
Albert ARIBAUD Sept. 21, 2012, 8:22 p.m. UTC | #4
Hi Tom, Marek,

On Fri, 21 Sep 2012 11:13:50 -0700, Tom Rini <trini@ti.com> wrote:

> >> I've applied this.  But please note: Testing edminiv2 on 
> >> -00600-g50d924b Fri Sep 21 10:57:25 MST 2012 Configuring for 
> >> edminiv2 board... text    data     bss     dec     hex filename 
> >> 195013    3536   86692  285241   45a39 edminiv2/u-boot 
> >> ehci-hcd.c: In function 'ehci_submit_async': ehci-hcd.c:291:2: 
> >> warning: #warning CONFIG_SYS_MALLOC_LEN may be too small for
> >> EHCI [-Wcpp]
> >> 
> >> --------------------- SUMMARY ----------------------------
> >> Boards compiled: 1 Boards with warnings but no errors: 1 (
> >> edminiv2 ) 
> >> ----------------------------------------------------------
> >> 
> >> Albert, this is your platform.
> > 
> > Did this explode only now? This warning was added a while ago.
> 
> Yes, it's one of the differences in my logs before and after.

I've just seen it while merging u-boot/master for regression before
requestion pull of ARM. Bumping up to 256KB makes the warning disappear;
I'll be running tests on the board once I am done with Tom's and my pull
reqs. 

Amicalement,