From patchwork Thu Sep 20 03:22:50 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhenqiang Chen X-Patchwork-Id: 185303 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 574672C0099 for ; Thu, 20 Sep 2012 13:23:11 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=sourceware.org; s=default; x=1348716192; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:Received:In-Reply-To:References:Date: Message-ID:Subject:From:To:Cc:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Subscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=9c88S5Xl+yTBiRPI4Bku qHvfTuw=; b=aLrpgaamHCBhveWY5AN+KYlfuBCMAX6gddSfdGfRdtfA9VIM2SpR GoNm+HCSPcDJLPeK7q8MbhBtrgAYxOgguanFG4vhU22ZDfyZTufCTRK8xS8/g3/r NJ8QgWNEbTRpl6oRaOxLYNVUlVjpJ0g2QNlr36KpiMQT+8FvIz1JV18= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=sourceware.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:MIME-Version:Received:Received:In-Reply-To:References:Date:Message-ID:Subject:From:To:Cc:Content-Type:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Subscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=H792awrbYv62Lk9uWGRVzbURNLEOIhAaaDoGOVFV7IX7SmMjA/W90dAKv29Qya MwSe6DaT69XXdkAG9D4PRm5djTTeceNzzKfdjPKWRP8ALvpUyQ7MqDR7cmsBngPf wAoeTtHLQbkpAdxJbJH+CgkkNSsdNT6whAPn19/6HyKK0=; Received: (qmail 17693 invoked by alias); 20 Sep 2012 03:23:07 -0000 Received: (qmail 17685 invoked by uid 22791); 20 Sep 2012 03:23:06 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Sep 2012 03:22:52 +0000 Received: by vbkv13 with SMTP id v13so2207343vbk.0 for ; Wed, 19 Sep 2012 20:22:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=O9B8SvnfEP8UTEbTwCSduxxWapvh7n9qqUVVRdtL3LE=; b=TiAGsT/glGhHa0lXzPbXDuW5WZ+tHZgALNFqdgWOX9mppLH5I0TfCEbfxQyHuef+NV wk63kQvaBEHkt8iWa2O+3tnB8icY8jUGu2GpoYIX5pxdj1Yk56QfIi8O6+Rk7ohic+N9 yAenndDPFSXsAznbxqm7ZqQMwORD7cLd9Uwt7G6HNPNKV01+Y3+ldGcV/yvtbhskK3G6 RSJTrDZ2P9b4lrVsgE1o/Dgm1aBWl9kTZgtzMAIKRZ9g13ErFOooPBxq3G+zG31jGe3K 8u5Epdj5mEeTsgrkq/+ktRmn9PiFFLtbvNvU9lS47Shvs7bwi77GUoAf1IbAcYWyliqZ YCfw== MIME-Version: 1.0 Received: by 10.58.117.103 with SMTP id kd7mr347375veb.4.1348111371189; Wed, 19 Sep 2012 20:22:51 -0700 (PDT) Received: by 10.58.133.161 with HTTP; Wed, 19 Sep 2012 20:22:50 -0700 (PDT) In-Reply-To: <201209192304.42508.yann.morin.1998@free.fr> References: <201209190205.27782.vapier@gentoo.org> <201209192304.42508.yann.morin.1998@free.fr> Date: Thu, 20 Sep 2012 11:22:50 +0800 Message-ID: Subject: Re: [PATCH] scripts: Select the correct "strip" to strip gdbserver for Canadian build From: Zhenqiang Chen To: "Yann E. MORIN" Cc: crossgcc@sourceware.org, Mike Frysinger X-Gm-Message-State: ALoCoQm2jhJc8sU4JgjkLNHF7AJQMXoCRP7vOIK6ZtdNVYW3P5tlgAeoLYom0MXSNC+ttB101EQO X-IsSubscribed: yes Mailing-List: contact crossgcc-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: crossgcc-owner@sourceware.org Delivered-To: mailing list crossgcc@sourceware.org On 20 September 2012 05:04, Yann E. MORIN wrote: > Zhenqiang, Mike, All, > > On Wednesday 19 September 2012 10:56:18 Zhenqiang Chen wrote: >> # HG changeset patch >> # User Zhenqiang Chen >> # Date 1348044842 -28800 >> # Node ID 49dc965c5eada0b4bbef5f7810a259eae5773bb1 >> # Parent 2858a24a584642e263a920b4214c815c172ed547 >> scripts: Select the correct "strip" to strip gdbserver for Canadian build. >> >> For Canadian build, we can not run the bin/${CT_TARGET}-strip on the build >> system. But ${CT_TARGET}-strip should be on PATH. >> >> Signed-off-by: Zhenqiang Chen >> >> diff -r 2858a24a5846 -r 49dc965c5ead scripts/build/internals.sh >> --- a/scripts/build/internals.sh Sun Aug 12 07:45:42 2012 -0400 >> +++ b/scripts/build/internals.sh Wed Sep 19 16:54:02 2012 +0800 >> @@ -25,8 +25,12 @@ >> >> # Strip gdbserver >> if [ "${CT_GDB_GDBSERVER}" = "y" ]; then >> - CT_DoExecLog ALL bin/${CT_TARGET}-strip ${strip_args} \ >> - ${CT_TARGET}/debug-root/usr/bin/gdbserver >> + local cross_strip="bin/${CT_TARGET}-strip" >> + # For Canadian build, we can not run the bin/${CT_TARGET}-strip on >> + # the build system. But ${CT_TARGET}-strip should be on PATH. >> + [ "${CT_CANADIAN}" = "y" ] && cross_strip="${CT_TARGET}-strip" >> + CT_DoExecLog ALL ${cross_strip} ${strip_args} \ >> + ${CT_TARGET}/debug-root/usr/bin/gdbserver > > Just call ${CT_TARGET}-strip : > - if in cross-mode, then we can run it from the final installation > location ${CT_PREFIX_DIR}/bin, which is in the $PATH > - if in canadian-mode, then we can run it from the 'host' binutils > that was build earlier, and isntalled in ${CT_BUILDTOOLS_DIR}/bin, > which is also in the $PATH > > Note: in cross-mode, both ${CT_PREFIX_DIR}/bin and ${CT_BUILDTOOLS_DIR}/bin > are in the $PATH, in this order, to give precedence to the final location > over the build-time-only tools. In canadian-mode, only the latter is in the > $PATH, so we do not even have the possibility to run host code. > > Regards, > Yann E. MORIN. Thanks! Update it as: exporting patch: # HG changeset patch # User Zhenqiang Chen # Date 1348111216 -28800 # Node ID 8724aedc7a30ac1e5c0a412747e5a88707da95a4 # Parent 2858a24a584642e263a920b4214c815c172ed547 scripts: Use ${CT_TARGET}-strip to strip gdbserver Signed-off-by: Zhenqiang Chen --- For unsubscribe information see http://sourceware.org/lists.html#faq diff -r 2858a24a5846 -r 8724aedc7a30 scripts/build/internals.sh --- a/scripts/build/internals.sh Sun Aug 12 07:45:42 2012 -0400 +++ b/scripts/build/internals.sh Thu Sep 20 11:20:16 2012 +0800 @@ -25,8 +25,8 @@ # Strip gdbserver if [ "${CT_GDB_GDBSERVER}" = "y" ]; then - CT_DoExecLog ALL bin/${CT_TARGET}-strip ${strip_args} \ - ${CT_TARGET}/debug-root/usr/bin/gdbserver + CT_DoExecLog ALL ${CT_TARGET}-strip ${strip_args} \ + ${CT_TARGET}/debug-root/usr/bin/gdbserver fi # We can not use the version in CT_CC_VERSION because # of the Linaro stuff. So, harvest the version string