Patchwork [U-Boot,v2,1/3] mx53loco: Change default environment to cope with OE changes

login
register
mail settings
Submitter Otavio Salvador
Date Sept. 19, 2012, 10:28 p.m.
Message ID <1348093693-27697-1-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/185239/
State Changes Requested
Delegated to: Stefano Babic
Headers show

Comments

Otavio Salvador - Sept. 19, 2012, 10:28 p.m.
OpenEmbedded has change partitioning layout of generated image so it
does not raise warnings during the boot regarding unkown partition
being used for U-Boot.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v2:
- no changes

 include/configs/mx53loco.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Stefano Babic - Sept. 20, 2012, 8:51 a.m.
On 20/09/2012 00:28, Otavio Salvador wrote:
> OpenEmbedded has change partitioning layout of generated image so it
> does not raise warnings during the boot regarding unkown partition
> being used for U-Boot.
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> Changes in v2:
> - no changes
> 
>  include/configs/mx53loco.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h
> index 8cbaf08..fcd6b44 100644
> --- a/include/configs/mx53loco.h
> +++ b/include/configs/mx53loco.h
> @@ -120,8 +120,8 @@
>  	"script=boot.scr\0" \
>  	"uimage=uImage\0" \
>  	"mmcdev=0\0" \
> -	"mmcpart=2\0" \
> -	"mmcroot=/dev/mmcblk0p3 rw\0" \
> +	"mmcpart=1\0" \
> +	"mmcroot=/dev/mmcblk0p2 rw\0" \
>  	"mmcrootfstype=ext3 rootwait\0" \
>  	"mmcargs=setenv bootargs console=ttymxc0,${baudrate} " \
>  		"root=${mmcroot} " \

I have no problem with these series, but anyway u-boot is not strictly
bound to OpenEmbedded.

Maybe you want to add CMD_SETEXPR to compute the partition number ?

Regards,
Stefano
Otavio Salvador - Sept. 21, 2012, 1:04 p.m.
On Thu, Sep 20, 2012 at 5:51 AM, Stefano Babic <sbabic@denx.de> wrote:
> On 20/09/2012 00:28, Otavio Salvador wrote:
>> OpenEmbedded has change partitioning layout of generated image so it
>> does not raise warnings during the boot regarding unkown partition
>> being used for U-Boot.
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>> Changes in v2:
>> - no changes
>>
>>  include/configs/mx53loco.h |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h
>> index 8cbaf08..fcd6b44 100644
>> --- a/include/configs/mx53loco.h
>> +++ b/include/configs/mx53loco.h
>> @@ -120,8 +120,8 @@
>>       "script=boot.scr\0" \
>>       "uimage=uImage\0" \
>>       "mmcdev=0\0" \
>> -     "mmcpart=2\0" \
>> -     "mmcroot=/dev/mmcblk0p3 rw\0" \
>> +     "mmcpart=1\0" \
>> +     "mmcroot=/dev/mmcblk0p2 rw\0" \
>>       "mmcrootfstype=ext3 rootwait\0" \
>>       "mmcargs=setenv bootargs console=ttymxc0,${baudrate} " \
>>               "root=${mmcroot} " \
>
> I have no problem with these series, but anyway u-boot is not strictly
> bound to OpenEmbedded.
>
> Maybe you want to add CMD_SETEXPR to compute the partition number ?

It might be done but I think it will be confusing if user needs to change it.

Patch

diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h
index 8cbaf08..fcd6b44 100644
--- a/include/configs/mx53loco.h
+++ b/include/configs/mx53loco.h
@@ -120,8 +120,8 @@ 
 	"script=boot.scr\0" \
 	"uimage=uImage\0" \
 	"mmcdev=0\0" \
-	"mmcpart=2\0" \
-	"mmcroot=/dev/mmcblk0p3 rw\0" \
+	"mmcpart=1\0" \
+	"mmcroot=/dev/mmcblk0p2 rw\0" \
 	"mmcrootfstype=ext3 rootwait\0" \
 	"mmcargs=setenv bootargs console=ttymxc0,${baudrate} " \
 		"root=${mmcroot} " \