From patchwork Wed Sep 19 20:00:18 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aurelien Jarno X-Patchwork-Id: 185209 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6FC9F2C007D for ; Thu, 20 Sep 2012 06:00:49 +1000 (EST) Received: from localhost ([::1]:51127 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEQRz-0003kJ-GO for incoming@patchwork.ozlabs.org; Wed, 19 Sep 2012 16:00:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEQRi-0003bk-Hh for qemu-devel@nongnu.org; Wed, 19 Sep 2012 16:00:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TEQRg-0002C2-Pl for qemu-devel@nongnu.org; Wed, 19 Sep 2012 16:00:30 -0400 Received: from hall.aurel32.net ([88.191.126.93]:52040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEQRg-00028j-HR for qemu-devel@nongnu.org; Wed, 19 Sep 2012 16:00:28 -0400 Received: from [2001:470:d4ed:1:2db:dfff:fe14:52d] (helo=ohm.aurel32.net) by hall.aurel32.net with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1TEQRf-00052Q-0z; Wed, 19 Sep 2012 22:00:27 +0200 Received: from aurel32 by ohm.aurel32.net with local (Exim 4.80) (envelope-from ) id 1TEQRd-0004os-7M; Wed, 19 Sep 2012 22:00:25 +0200 From: Aurelien Jarno To: qemu-devel@nongnu.org Date: Wed, 19 Sep 2012 22:00:18 +0200 Message-Id: <1348084823-18277-5-git-send-email-aurelien@aurel32.net> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1348084823-18277-1-git-send-email-aurelien@aurel32.net> References: <1348084823-18277-1-git-send-email-aurelien@aurel32.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 88.191.126.93 Cc: Aurelien Jarno Subject: [Qemu-devel] [PATCH 4/9] tcg/optimize: do copy propagation for all operations X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org It is possible to do copy propagation for all operations, even the ones that have side effects or clobber arguments (it only concerns input arguments). That said, the call operation should be handled differently due to the variable number of arguments. Signed-off-by: Aurelien Jarno Reviewed-by: Richard Henderson --- tcg/optimize.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 244eb02..a58de3b 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -376,8 +376,15 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr, op = gen_opc_buf[op_index]; def = &tcg_op_defs[op]; /* Do copy propagation */ - if (!(def->flags & (TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS))) { - assert(op != INDEX_op_call); + if (op == INDEX_op_call) { + int nb_oargs = args[0] >> 16; + int nb_iargs = args[0] & 0xffff; + for (i = nb_oargs + 1; i < nb_oargs + nb_iargs + 1; i++) { + if (temps[args[i]].state == TCG_TEMP_COPY) { + args[i] = find_better_copy(s, args[i]); + } + } + } else { for (i = def->nb_oargs; i < def->nb_oargs + def->nb_iargs; i++) { if (temps[args[i]].state == TCG_TEMP_COPY) { args[i] = find_better_copy(s, args[i]);