Patchwork [5/8] acpi: method: Add check for GSB

login
register
mail settings
Submitter Colin King
Date Sept. 19, 2012, 5:53 p.m.
Message ID <1348077237-3143-6-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/185119/
State Accepted
Headers show

Comments

Colin King - Sept. 19, 2012, 5:53 p.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpi/method/method.c |   10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
Keng-Yu Lin - Sept. 25, 2012, 3:11 a.m.
On Thu, Sep 20, 2012 at 1:53 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpi/method/method.c |   10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 272b662..e38b830 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -107,7 +107,7 @@
>   * _GPD  B.4.4         Y
>   * _GPE  5.3.1, 12.11  N
>   * _GRT  9.18.3                Y
> - * _GSB  6.2.6         N
> + * _GSB  6.2.6         Y
>   * _GTF  9.8.1.1       N
>   * _GTM  9.8.2.1.1     N
>   * _GTS  7.3.3         deprecated
> @@ -946,6 +946,12 @@ static int method_test_DIS(fwts_framework *fw)
>                 "_DIS", NULL, 0, method_test_NULL_return, NULL);
>  }
>
> +static int method_test_GSB(fwts_framework *fw)
> +{
> +       return method_evaluate_method(fw, METHOD_OPTIONAL,
> +               "_GSB", NULL, 0, method_test_integer_return, NULL);
> +}
> +
>  static int method_test_PXM(fwts_framework *fw)
>  {
>         return method_evaluate_method(fw, METHOD_OPTIONAL,
> @@ -3084,7 +3090,7 @@ static fwts_framework_minor_test method_tests[] = {
>         { method_test_DIS, "Check _DIS (Disable)." },
>         { method_test_DMA, "Check _DMA (Direct Memory Access)." },
>         /* { method_test_FIX, "Check _FIX (Fixed Register Resource Provider)." }, */
> -       /* { method_test_GSB, "Check _GSB (Global System Interrupt Base)." }, */
> +       { method_test_GSB, "Check _GSB (Global System Interrupt Base)." },
>         /* { method_test_HPP, "Check _HPP (Hot Plug Parameters)." }, */
>         /* { method_test_HPX, "Check _HPX (Hot Plug Extensions)." }, */
>         /* { method_test_MAT, "Check _MAT (Multiple APIC Table Entry)." }, */
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - Sept. 27, 2012, 4:56 p.m.
On 09/20/2012 01:53 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpi/method/method.c |   10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 272b662..e38b830 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -107,7 +107,7 @@
>    * _GPD  B.4.4		Y
>    * _GPE  5.3.1, 12.11	N
>    * _GRT  9.18.3		Y
> - * _GSB  6.2.6		N
> + * _GSB  6.2.6		Y
>    * _GTF  9.8.1.1	N
>    * _GTM  9.8.2.1.1	N
>    * _GTS  7.3.3		deprecated
> @@ -946,6 +946,12 @@ static int method_test_DIS(fwts_framework *fw)
>   		"_DIS", NULL, 0, method_test_NULL_return, NULL);
>   }
>
> +static int method_test_GSB(fwts_framework *fw)
> +{
> +	return method_evaluate_method(fw, METHOD_OPTIONAL,
> +		"_GSB", NULL, 0, method_test_integer_return, NULL);
> +}
> +
>   static int method_test_PXM(fwts_framework *fw)
>   {
>   	return method_evaluate_method(fw, METHOD_OPTIONAL,
> @@ -3084,7 +3090,7 @@ static fwts_framework_minor_test method_tests[] = {
>   	{ method_test_DIS, "Check _DIS (Disable)." },
>   	{ method_test_DMA, "Check _DMA (Direct Memory Access)." },
>   	/* { method_test_FIX, "Check _FIX (Fixed Register Resource Provider)." }, */
> -	/* { method_test_GSB, "Check _GSB (Global System Interrupt Base)." }, */
> +	{ method_test_GSB, "Check _GSB (Global System Interrupt Base)." },
>   	/* { method_test_HPP, "Check _HPP (Hot Plug Parameters)." }, */
>   	/* { method_test_HPX, "Check _HPX (Hot Plug Extensions)." }, */
>   	/* { method_test_MAT, "Check _MAT (Multiple APIC Table Entry)." }, */
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
index 272b662..e38b830 100644
--- a/src/acpi/method/method.c
+++ b/src/acpi/method/method.c
@@ -107,7 +107,7 @@ 
  * _GPD  B.4.4		Y
  * _GPE  5.3.1, 12.11	N
  * _GRT  9.18.3		Y
- * _GSB  6.2.6		N
+ * _GSB  6.2.6		Y
  * _GTF  9.8.1.1	N
  * _GTM  9.8.2.1.1	N
  * _GTS  7.3.3		deprecated
@@ -946,6 +946,12 @@  static int method_test_DIS(fwts_framework *fw)
 		"_DIS", NULL, 0, method_test_NULL_return, NULL);
 }
 
+static int method_test_GSB(fwts_framework *fw)
+{
+	return method_evaluate_method(fw, METHOD_OPTIONAL,
+		"_GSB", NULL, 0, method_test_integer_return, NULL);
+}
+
 static int method_test_PXM(fwts_framework *fw)
 {
 	return method_evaluate_method(fw, METHOD_OPTIONAL,
@@ -3084,7 +3090,7 @@  static fwts_framework_minor_test method_tests[] = {
 	{ method_test_DIS, "Check _DIS (Disable)." },
 	{ method_test_DMA, "Check _DMA (Direct Memory Access)." },
 	/* { method_test_FIX, "Check _FIX (Fixed Register Resource Provider)." }, */
-	/* { method_test_GSB, "Check _GSB (Global System Interrupt Base)." }, */
+	{ method_test_GSB, "Check _GSB (Global System Interrupt Base)." },
 	/* { method_test_HPP, "Check _HPP (Hot Plug Parameters)." }, */
 	/* { method_test_HPX, "Check _HPX (Hot Plug Extensions)." }, */
 	/* { method_test_MAT, "Check _MAT (Multiple APIC Table Entry)." }, */