Patchwork Add -Og -g to TORTURE_OPTIONS

login
register
mail settings
Submitter Richard Guenther
Date Sept. 19, 2012, 1:51 p.m.
Message ID <alpine.LNX.2.00.1209191551320.28649@zhemvz.fhfr.qr>
Download mbox | patch
Permalink /patch/185047/
State New
Headers show

Comments

Richard Guenther - Sept. 19, 2012, 1:51 p.m.
Which passes testing now.

Ok?

Thanks,
Richard.

2012-09-19  Richard Guenther  <rguenther@suse.de>

	* lib/c-torture.exp (TORTURE_OPTIONS): Add -Og -g.
Jakub Jelinek - Sept. 19, 2012, 1:58 p.m.
On Wed, Sep 19, 2012 at 03:51:56PM +0200, Richard Guenther wrote:
> Which passes testing now.
> 
> Ok?

Yes.  Probably we'll need to retune parallel checking, but we probably need
to do it anyway already now, e.g. i386.exp grew too much.

	Jakub
Richard Guenther - Sept. 19, 2012, 2:01 p.m.
On Wed, 19 Sep 2012, Jakub Jelinek wrote:

> On Wed, Sep 19, 2012 at 03:51:56PM +0200, Richard Guenther wrote:
> > Which passes testing now.
> > 
> > Ok?
> 
> Yes.  Probably we'll need to retune parallel checking, but we probably need
> to do it anyway already now, e.g. i386.exp grew too much.

Committed.

Eventually we can shave off some time by removing any of the -O3
options:

    set C_TORTURE_OPTIONS [list \
        { -O0 } \
        { -O1 } \
        { -O2 } \
        { -O3 -fomit-frame-pointer } \
        { -O3 -fomit-frame-pointer -funroll-loops } \
        { -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions } 
\
        { -O3 -g } \
        { -Os } \
        { -Og -g } ]

-O3 and -Os already enable -finline-functions for example, likewise
-fomit-frame-pointer is enabled on most targets.  For testing coverage
-funroll-all-loops should trump -funroll-loops, and rather than
disabling frame-pointers I'd explicitely enable them.  Thus keep

  -O3 -fno-omit-frame-pointer
  -O3 -funroll-all-loops
  -O3 -g

(not sure why we have -g at -O3 but not at -O[012s] where it should
be more common ...)

Richard.

Patch

Index: gcc/testsuite/lib/c-torture.exp
===================================================================
--- gcc/testsuite/lib/c-torture.exp	(revision 191474)
+++ gcc/testsuite/lib/c-torture.exp	(working copy)
@@ -42,7 +42,8 @@  if [info exists TORTURE_OPTIONS] {
 	{ -O3 -fomit-frame-pointer -funroll-loops } \
 	{ -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions } \
 	{ -O3 -g } \
-	{ -Os } ]
+	{ -Os } \
+	{ -Og -g } ]
 }
 
 if [info exists ADDITIONAL_TORTURE_OPTIONS] {