Patchwork [v2,2/2] ccid: new package

login
register
mail settings
Submitter Waldemar Rymarkiewicz
Date Sept. 19, 2012, 12:52 p.m.
Message ID <1348059150-32601-2-git-send-email-waldemar.rymarkiewicz@tieto.com>
Download mbox | patch
Permalink /patch/185028/
State Superseded
Headers show

Comments

Waldemar Rymarkiewicz - Sept. 19, 2012, 12:52 p.m.
PC/SC driver for USB CCID smart card readers.

http://pcsclite.alioth.debian.org/ccid.html

Signed-off-by: Waldemar Rymarkiewicz <waldemar.rymarkiewicz@tieto.com>
---
 package/Config.in      |    1 +
 package/ccid/Config.in |   11 +++++++++++
 package/ccid/ccid.mk   |   19 +++++++++++++++++++
 3 files changed, 31 insertions(+)
 create mode 100644 package/ccid/Config.in
 create mode 100644 package/ccid/ccid.mk
Arnout Vandecappelle - Sept. 19, 2012, 8:56 p.m.
On 09/19/12 14:52, Waldemar Rymarkiewicz wrote:
> PC/SC driver for USB CCID smart card readers.
[snip]
> +ifeq ($(BR2_PACKAGE_LIBUSB),y)
> +CCID_CONF_OPT += --enable-libusb
> +CCID_DEPENDENCIES += libusb
> +else
> +CCID_CONF_OPT += --disable-libusb
> +endif
> +
> +$(eval $(call autotools-package))

  I just build-tested on a config without libusb, and it doesn't seem
to install anything.  The examples are compiled (not installed), but
I doubt they're useful for anything without the ccid plugin.

  So maybe it's better to select libusb after all.

  Regards,
  Arnout
Waldemar Rymarkiewicz - Sept. 20, 2012, 6:31 a.m.
Arnout,

>[snip]
>> +ifeq ($(BR2_PACKAGE_LIBUSB),y)
>> +CCID_CONF_OPT += --enable-libusb
>> +CCID_DEPENDENCIES += libusb
>> +else
>> +CCID_CONF_OPT += --disable-libusb
>> +endif
>> +
>> +$(eval $(call autotools-package))
>
>  I just build-tested on a config without libusb, and it doesn't seem
>to install anything.  The examples are compiled (not installed), but
>I doubt they're useful for anything without the ccid plugin.
>
>  So maybe it's better to select libusb after all.

You are right. I missed that. 

It seems that ccid itself is broken and this option does not work as supposed so I will require libusb then. 

Thanks,
/Waldek

Patch

diff --git a/package/Config.in b/package/Config.in
index dcc84b6..a0fb593 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -382,6 +382,7 @@  source "package/zxing/Config.in"
 endmenu
 
 menu "Hardware handling"
+source "package/ccid/Config.in"
 source "package/libaio/Config.in"
 source "package/libraw1394/Config.in"
 source "package/tslib/Config.in"
diff --git a/package/ccid/Config.in b/package/ccid/Config.in
new file mode 100644
index 0000000..d67bc0e
--- /dev/null
+++ b/package/ccid/Config.in
@@ -0,0 +1,11 @@ 
+config BR2_PACKAGE_CCID
+	bool "ccid"
+	select BR2_PACKAGE_PCSC_LITE
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	help
+	  PC/SC driver for USB CCID smart card readers
+
+	  http://pcsclite.alioth.debian.org/ccid.html
+
+comment "ccid needs a toolchain with thread support"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/ccid/ccid.mk b/package/ccid/ccid.mk
new file mode 100644
index 0000000..cb59451
--- /dev/null
+++ b/package/ccid/ccid.mk
@@ -0,0 +1,19 @@ 
+##########################################################
+#
+# CCID
+#
+# ########################################################
+CCID_VERSION = 1.4.7
+CCID_SOURCE = ccid-$(CCID_VERSION).tar.bz2
+CCID_SITE = https://alioth.debian.org/frs/download.php/3730
+CCID_INSTALL_STAGING = YES
+CCID_DEPENDENCIES = pcsc-lite host-pkg-config
+
+ifeq ($(BR2_PACKAGE_LIBUSB),y)
+CCID_CONF_OPT += --enable-libusb
+CCID_DEPENDENCIES += libusb
+else
+CCID_CONF_OPT += --disable-libusb
+endif
+
+$(eval $(call autotools-package))