| Message ID | 1348053493-22955-1-git-send-email-jarl@softace.dk |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi Jarl, You should really mention which driver these are for in the subject line, say: [PATCH] b43: Added information about which firmware file is being requested On Wed, Sep 19, 2012 at 9:18 PM, Jarl Friis <jarl@softace.dk> wrote: > This is informative information to provide about which actual firmware > file is being used. Also, this patch is so small and obvious that you could arguably get away with something like: Subject: [PATCH] b43: Log firmware filename Log the name of the firmware file requested. Or something along those lines. Thanks,
On 19.09.2012 15:18, Jarl Friis wrote: > + b43info(ctx->dev->wl, "Requesting firmware file '%s'\n", ctx->fwname); > err = request_firmware(&blob, ctx->fwname, ctx->dev->dev->dev); Hmm. I wonder if this should be printed in request_firmware() itself instead of in all callers? /mjt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2012/9/19 Michael Tokarev <mjt@tls.msk.ru>: > On 19.09.2012 15:18, Jarl Friis wrote: > >> + b43info(ctx->dev->wl, "Requesting firmware file '%s'\n", ctx->fwname); >> err = request_firmware(&blob, ctx->fwname, ctx->dev->dev->dev); > > Hmm. I wonder if this should be printed in request_firmware() > itself instead of in all callers? Now that you mention it, I also think that is a much better idea. However that would be a much more central place to do the change, so I would gladly see somebody else do that patch (in replacement of mine) Jarl -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2012/9/19 Jarl Friis <jarl@softace.dk>: > 2012/9/19 Michael Tokarev <mjt@tls.msk.ru>: >> On 19.09.2012 15:18, Jarl Friis wrote: >> >>> + b43info(ctx->dev->wl, "Requesting firmware file '%s'\n", ctx->fwname); >>> err = request_firmware(&blob, ctx->fwname, ctx->dev->dev->dev); >> >> Hmm. I wonder if this should be printed in request_firmware() >> itself instead of in all callers? > > Now that you mention it, I also think that is a much better idea. > However that would be a much more central place to do the change, so I > would gladly see somebody else do that patch (in replacement of mine) I agree, please submit patch modifying request_firmware if you believe it's important.
diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c index a140165..202a0eb 100644 --- a/drivers/net/wireless/b43/main.c +++ b/drivers/net/wireless/b43/main.c @@ -2131,6 +2131,7 @@ int b43_do_request_fw(struct b43_request_fw_context *ctx, B43_WARN_ON(1); return -ENOSYS; } + b43info(ctx->dev->wl, "Requesting firmware file '%s'\n", ctx->fwname); err = request_firmware(&blob, ctx->fwname, ctx->dev->dev->dev); if (err == -ENOENT) { snprintf(ctx->errors[ctx->req_type],
This is informative information to provide about which actual firmware file is being used. Signed-off-by: Jarl Friis <jarl@softace.dk> --- drivers/net/wireless/b43/main.c | 1 + 1 file changed, 1 insertion(+)