From patchwork Wed Sep 19 02:40:41 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [5/6] PCI/AER: introduce pci_bus_ops_free to free pci_bus_ops Date: Tue, 18 Sep 2012 16:40:41 -0000 From: Yijing Wang X-Patchwork-Id: 184908 Message-Id: <1348022442-7816-6-git-send-email-wangyijing@huawei.com> To: Bjorn Helgaas , Huang Ying , Chen Gong Cc: , Hanjun Guo , , Yijing Wang Signed-off-by: Yijing Wang --- drivers/pci/pcie/aer/aer_inject.c | 14 +++++++++++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/pci/pcie/aer/aer_inject.c b/drivers/pci/pcie/aer/aer_inject.c index 0a12ac7..79b611d 100644 --- a/drivers/pci/pcie/aer/aer_inject.c +++ b/drivers/pci/pcie/aer/aer_inject.c @@ -162,6 +162,16 @@ static struct pci_bus_ops *pci_bus_ops_pop(void) return bus_ops; } +static void pci_bus_ops_free(void) +{ + struct pci_bus_ops *bus_ops, *tmp_ops; + + list_for_each_entry_safe(bus_ops, tmp_ops, &pci_bus_ops_list, list) { + list_del(&bus_ops->list); + kfree(bus_ops); + } +} + static struct pci_bus_ops *pci_bus_ops_get(struct pci_bus_ops *from) { struct pci_bus_ops *bus_ops = NULL; @@ -641,9 +651,7 @@ static void __exit aer_inject_exit(void) * module exit */ clean_untracked_pci_ops_aer(); - - while ((bus_ops = pci_bus_ops_pop())) - kfree(bus_ops); + pci_bus_ops_free(); spin_lock_irqsave(&inject_lock, flags); list_for_each_entry_safe(err, err_next, &einjected, list) {