Patchwork acpi: apcidump: Add ACPI 5.0 support for boot flag CMOS RTC present bit

login
register
mail settings
Submitter Colin King
Date Sept. 18, 2012, 1:17 p.m.
Message ID <1347974244-19168-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/184711/
State Accepted
Headers show

Comments

Colin King - Sept. 18, 2012, 1:17 p.m.
From: Colin Ian King <colin.king@canonical.com>

ACPI 5.0 adds a "CMOS RTC Not Present" bit (bit 5) to the FADT BOOT_ARCH
flags, so include it in acpidump.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpi/acpidump/acpidump.c |    1 +
 1 file changed, 1 insertion(+)
Alex Hung - Sept. 20, 2012, 6:45 a.m.
On 09/18/2012 09:17 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> ACPI 5.0 adds a "CMOS RTC Not Present" bit (bit 5) to the FADT BOOT_ARCH
> flags, so include it in acpidump.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpi/acpidump/acpidump.c |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/acpi/acpidump/acpidump.c b/src/acpi/acpidump/acpidump.c
> index bd75da6..394821f 100644
> --- a/src/acpi/acpidump/acpidump.c
> +++ b/src/acpi/acpidump/acpidump.c
> @@ -622,6 +622,7 @@ static void acpidump_fadt(fwts_framework *fw, fwts_acpi_table_info *table)
>   		FIELD_BITF("  VGA Not Present (V4)",			fwts_acpi_table_fadt, iapc_boot_arch, 1, 2),
>   		FIELD_BITF("  MSI Not Supported (V4)",			fwts_acpi_table_fadt, iapc_boot_arch, 1, 3),
>   		FIELD_BITF("  PCIe ASPM Not supported (V4)",		fwts_acpi_table_fadt, iapc_boot_arch, 1, 4),
> +		FIELD_BITF("  CMOS RTC Not Present (V5)",		fwts_acpi_table_fadt, iapc_boot_arch, 1, 5),
>   		FIELD_UINT("Flags (see below)", 			fwts_acpi_table_fadt, flags),
>   		FIELD_BITF("  WBINVD instruction (V1)", 		fwts_acpi_table_fadt, flags, 1, 0),
>   		FIELD_BITF("  WBINVD flushes all caches (V1)", 		fwts_acpi_table_fadt, flags, 1, 1),
>
Acked-by: Alex Hung <alex.hung@canonical.com>
Keng-Yu Lin - Sept. 20, 2012, 8:34 a.m.
On Tue, Sep 18, 2012 at 9:17 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> ACPI 5.0 adds a "CMOS RTC Not Present" bit (bit 5) to the FADT BOOT_ARCH
> flags, so include it in acpidump.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpi/acpidump/acpidump.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/acpi/acpidump/acpidump.c b/src/acpi/acpidump/acpidump.c
> index bd75da6..394821f 100644
> --- a/src/acpi/acpidump/acpidump.c
> +++ b/src/acpi/acpidump/acpidump.c
> @@ -622,6 +622,7 @@ static void acpidump_fadt(fwts_framework *fw, fwts_acpi_table_info *table)
>                 FIELD_BITF("  VGA Not Present (V4)",                    fwts_acpi_table_fadt, iapc_boot_arch, 1, 2),
>                 FIELD_BITF("  MSI Not Supported (V4)",                  fwts_acpi_table_fadt, iapc_boot_arch, 1, 3),
>                 FIELD_BITF("  PCIe ASPM Not supported (V4)",            fwts_acpi_table_fadt, iapc_boot_arch, 1, 4),
> +               FIELD_BITF("  CMOS RTC Not Present (V5)",               fwts_acpi_table_fadt, iapc_boot_arch, 1, 5),
>                 FIELD_UINT("Flags (see below)",                         fwts_acpi_table_fadt, flags),
>                 FIELD_BITF("  WBINVD instruction (V1)",                 fwts_acpi_table_fadt, flags, 1, 0),
>                 FIELD_BITF("  WBINVD flushes all caches (V1)",          fwts_acpi_table_fadt, flags, 1, 1),
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/src/acpi/acpidump/acpidump.c b/src/acpi/acpidump/acpidump.c
index bd75da6..394821f 100644
--- a/src/acpi/acpidump/acpidump.c
+++ b/src/acpi/acpidump/acpidump.c
@@ -622,6 +622,7 @@  static void acpidump_fadt(fwts_framework *fw, fwts_acpi_table_info *table)
 		FIELD_BITF("  VGA Not Present (V4)",			fwts_acpi_table_fadt, iapc_boot_arch, 1, 2),
 		FIELD_BITF("  MSI Not Supported (V4)",			fwts_acpi_table_fadt, iapc_boot_arch, 1, 3),
 		FIELD_BITF("  PCIe ASPM Not supported (V4)",		fwts_acpi_table_fadt, iapc_boot_arch, 1, 4),
+		FIELD_BITF("  CMOS RTC Not Present (V5)",		fwts_acpi_table_fadt, iapc_boot_arch, 1, 5),
 		FIELD_UINT("Flags (see below)", 			fwts_acpi_table_fadt, flags),
 		FIELD_BITF("  WBINVD instruction (V1)", 		fwts_acpi_table_fadt, flags, 1, 0),
 		FIELD_BITF("  WBINVD flushes all caches (V1)", 		fwts_acpi_table_fadt, flags, 1, 1),