From patchwork Tue Sep 18 11:23:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [3/3] acpi: acpitables: Add checks for MADT GIC and GICD Date: Tue, 18 Sep 2012 01:23:00 -0000 From: Colin King X-Patchwork-Id: 184677 Message-Id: <1347967380-24722-4-git-send-email-colin.king@canonical.com> To: fwts-devel@lists.ubuntu.com From: Colin Ian King Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Keng-Yu Lin --- src/acpi/acpitables/acpitables.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c index 7f1a748..3a71456 100644 --- a/src/acpi/acpitables/acpitables.c +++ b/src/acpi/acpitables/acpitables.c @@ -397,6 +397,21 @@ static void acpi_table_check_madt(fwts_framework *fw, fwts_acpi_table_info *tabl skip = (sizeof(fwts_acpi_madt_local_x2apic_nmi)); } break; + case 11: { + fwts_acpi_madt_gic *gic = (fwts_acpi_madt_gic*)data; + + if (gic->flags & 0xfffffffc) + fwts_failed(fw, LOG_LEVEL_MEDIUM, "MADTGICFLags", + "MADT GIC, flags, bits 2..31 are reserved " + "and should be zero, but are set as: %lx.", + (unsigned long int)gic->flags); + skip = sizeof(fwts_acpi_madt_gic); + } + break; + case 12: + /* Not much to sanity check */ + skip = sizeof(fwts_acpi_madt_gicd); + break; default: skip = 0; break;