From patchwork Tue Sep 18 11:23:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 184677 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 5EB2C2C0086 for ; Tue, 18 Sep 2012 21:23:05 +1000 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TDvrR-0004O5-63; Tue, 18 Sep 2012 11:21:01 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TDvrP-0004Nd-7K for fwts-devel@lists.ubuntu.com; Tue, 18 Sep 2012 11:20:59 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1TDvtO-0006QU-Eq for fwts-devel@lists.ubuntu.com; Tue, 18 Sep 2012 11:23:02 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH 3/3] acpi: acpitables: Add checks for MADT GIC and GICD Date: Tue, 18 Sep 2012 12:23:00 +0100 Message-Id: <1347967380-24722-4-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1347967380-24722-1-git-send-email-colin.king@canonical.com> References: <1347967380-24722-1-git-send-email-colin.king@canonical.com> X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: fwts-devel-bounces@lists.ubuntu.com Errors-To: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Keng-Yu Lin --- src/acpi/acpitables/acpitables.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c index 7f1a748..3a71456 100644 --- a/src/acpi/acpitables/acpitables.c +++ b/src/acpi/acpitables/acpitables.c @@ -397,6 +397,21 @@ static void acpi_table_check_madt(fwts_framework *fw, fwts_acpi_table_info *tabl skip = (sizeof(fwts_acpi_madt_local_x2apic_nmi)); } break; + case 11: { + fwts_acpi_madt_gic *gic = (fwts_acpi_madt_gic*)data; + + if (gic->flags & 0xfffffffc) + fwts_failed(fw, LOG_LEVEL_MEDIUM, "MADTGICFLags", + "MADT GIC, flags, bits 2..31 are reserved " + "and should be zero, but are set as: %lx.", + (unsigned long int)gic->flags); + skip = sizeof(fwts_acpi_madt_gic); + } + break; + case 12: + /* Not much to sanity check */ + skip = sizeof(fwts_acpi_madt_gicd); + break; default: skip = 0; break;