From patchwork Tue Sep 18 08:32:46 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 184654 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 980532C0083 for ; Tue, 18 Sep 2012 18:33:49 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1348562030; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:From:To:Cc:Subject:Date:Message-ID:User-Agent: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=bO/5VpQs7ooRgTJrAbYg/zNpj9o=; b=XoLUKDQ0EYAxIRY scwQgEbKpTSeteo3Lbx24Ra8DdVg0isFTI/icSNBlOK1o13LYLW4tgVQWjOtvwBc rJKWqR0Z5NOfX3Wy6LgzQFA4/kTxsn0MzulaOx7JD6aDgAZ1P4zh6MsOL6M3NB8J UhttbSfz1XRKoC1RXyB6SSZDP6nE= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:From:To:Cc:Subject:Date:Message-ID:User-Agent:MIME-Version:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=jzr6Jc9KfYs4XgDKxmJ78PkFQ2sky74lvwmqqUwzqPVROHlPRlJpUZw5Aj2tkO mLPXpMOA0JWVU8Pad3esmA2Hc1TV0M6rr38Mckw5aVF8BmACe55hh6BlKuIvlTuv DVrPZ2Swo2s4GzOaqIjUJj3eXxdYIzjpDknA3mNFypLxA=; Received: (qmail 30404 invoked by alias); 18 Sep 2012 08:33:34 -0000 Received: (qmail 30381 invoked by uid 22791); 18 Sep 2012 08:33:31 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Sep 2012 08:32:50 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id C6AA68B8; Tue, 18 Sep 2012 10:32:48 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id YDxIbnn-cQm5; Tue, 18 Sep 2012 10:32:47 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id E838F8B7; Tue, 18 Sep 2012 10:32:46 +0200 (CEST) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.5+Sun/8.14.5/Submit) id q8I8Wkiw008869; Tue, 18 Sep 2012 10:32:46 +0200 (MEST) From: Rainer Orth To: gcc-patches@gcc.gnu.org Cc: Ian Lance Taylor Subject: [libbacktrace] Fix bootstrap with gcc 4.4 Date: Tue, 18 Sep 2012 10:32:46 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org The libbacktrace integration broke Solaris 10 and 11 bootstrap when using gcc 4.4 (any version of gcc without __sync_* support actually): stage1 config.h has /* #undef HAVE_SYNC_FUNCTIONS */ and fileline.c and mmap.c fail to compile: /vol/gcc/src/hg/trunk/local/libbacktrace/fileline.c: In function 'fileline_init alize': /vol/gcc/src/hg/trunk/local/libbacktrace/fileline.c:58: error: implicit declarat ion of function 'abort' The following patch fixes this by including for the abort() declaration in the affected files. It allows the Solaris 11 bootstrap to continue. Ok for mainline? Unfortunately, Solaris 10 (and certainly Solaris 9, too) bootstrap is still broken: /vol/gcc/src/hg/trunk/local/libbacktrace/dwarf.c:652: error: implicit declaration of function 'strnlen' make[1]: *** [dwarf.lo] Error 1 Both completely lack strnlen(). I haven't done anything about this yet. Rainer 2012-09-18 Rainer Orth * fileline.c: Include . * mmap.c: Likewise. # HG changeset patch # Parent a22dd5d7246fa4e8a73de2e66db7594cf9ae9f5a Fix bootstrap with gcc 4.4 diff --git a/libbacktrace/fileline.c b/libbacktrace/fileline.c --- a/libbacktrace/fileline.c +++ b/libbacktrace/fileline.c @@ -35,6 +35,7 @@ POSSIBILITY OF SUCH DAMAGE. */ #include #include #include +#include #include "backtrace.h" #include "internal.h" diff --git a/libbacktrace/mmap.c b/libbacktrace/mmap.c --- a/libbacktrace/mmap.c +++ b/libbacktrace/mmap.c @@ -34,6 +34,7 @@ POSSIBILITY OF SUCH DAMAGE. */ #include #include +#include #include #include