Patchwork scripts: Skip gdbserver stripping for Canadian build

login
register
mail settings
Submitter Zhenqiang Chen
Date Sept. 18, 2012, 6:24 a.m.
Message ID <CACgzC7DcL=c7OpTXeaiuUzwP6-a+=OwpasVDrbOszZjMh=hjpA@mail.gmail.com>
Download mbox | patch
Permalink /patch/184621/
State Superseded
Headers show

Comments

Zhenqiang Chen - Sept. 18, 2012, 6:24 a.m.
exporting patch:
# HG changeset patch
# User Zhenqiang Chen <zhenqiang.chen@linaro.org>
# Date 1347948509 -28800
# Node ID 2f8f068268ebf8ea9a6e1470017e556e71251cf7
# Parent  fbfb29e9e1bff98b7302fbaf67b296d94f082c18
scripts: Skip gdbserver stripping for Canadian build.

For Canadian build, we can not run the bin/${CT_TARGET}-strip on
the build system.

Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>


--
For unsubscribe information see http://sourceware.org/lists.html#faq
Mike Frysinger - Sept. 18, 2012, 6:44 a.m.
On Tuesday 18 September 2012 02:24:07 Zhenqiang Chen wrote:
> For Canadian build, we can not run the bin/${CT_TARGET}-strip on
> the build system.

in order to do a canadian build, you've got to have a proper strip somewhere 
which can process target code.  so why not execute that instead ?
-mike
Zhenqiang Chen - Sept. 18, 2012, 8:56 a.m.
On 18 September 2012 14:44, Mike Frysinger <vapier@gentoo.org> wrote:
> On Tuesday 18 September 2012 02:24:07 Zhenqiang Chen wrote:
>> For Canadian build, we can not run the bin/${CT_TARGET}-strip on
>> the build system.
>
> in order to do a canadian build, you've got to have a proper strip somewhere
> which can process target code.  so why not execute that instead ?

Thanks for the comments. I will update it.

-Zhenqiang

--
For unsubscribe information see http://sourceware.org/lists.html#faq

Patch

diff -r fbfb29e9e1bf -r 2f8f068268eb scripts/build/internals.sh
--- a/scripts/build/internals.sh        Tue Sep 18 13:26:18 2012 +0800
+++ b/scripts/build/internals.sh        Tue Sep 18 14:08:29 2012 +0800
@@ -25,8 +25,12 @@ 

         # Strip gdbserver
         if [ "${CT_GDB_GDBSERVER}" = "y" ]; then
-           CT_DoExecLog ALL bin/${CT_TARGET}-strip ${strip_args}    \
-                            ${CT_TARGET}/debug-root/usr/bin/gdbserver
+           # Skip for Canadian build, since we can not run the
+           # bin/${CT_TARGET}-strip on the build system.
+           if [ "${CT_CANADIAN}" != "y" ]; then
+               CT_DoExecLog ALL bin/${CT_TARGET}-strip ${strip_args}    \
+                                ${CT_TARGET}/debug-root/usr/bin/gdbserver
+           fi
         fi
         # We can not use the version in CT_CC_VERSION because
         # of the Linaro stuff. So, harvest the version string