Patchwork libsndfile: Add dependency on BR2_LARGEFILE

login
register
mail settings
Submitter Ryan Mallon
Date Sept. 18, 2012, 5:09 a.m.
Message ID <505801FF.20207@gmail.com>
Download mbox | patch
Permalink /patch/184611/
State Superseded
Headers show

Comments

Ryan Mallon - Sept. 18, 2012, 5:09 a.m.
libsndfile requires sizeof(sf_count_t) == 8, where sf_count_t is a
typedef alias for off_t. This is not true by default for all
tool-chains, which leads to a runtime assert failure in binaries
compiled against libsndfile. See:
    
  http://permalink.gmane.org/gmane.comp.audio.libsndfile.devel/229
    
Add a dependency on BR2_LARGEFILE for libsndfile, and a comment if
BR2_LARGEFILE is not selected.
    
Signed-off-by: Ryan Mallon <rmallon@gmail.com>
---
Thomas Petazzoni - Sept. 18, 2012, 5:55 a.m.
Dear Ryan Mallon,

On Tue, 18 Sep 2012 15:09:19 +1000, Ryan Mallon wrote:
> libsndfile requires sizeof(sf_count_t) == 8, where sf_count_t is a
> typedef alias for off_t. This is not true by default for all
> tool-chains, which leads to a runtime assert failure in binaries
> compiled against libsndfile. See:
>     
>   http://permalink.gmane.org/gmane.comp.audio.libsndfile.devel/229
>     
> Add a dependency on BR2_LARGEFILE for libsndfile, and a comment if
> BR2_LARGEFILE is not selected.
>     
> Signed-off-by: Ryan Mallon <rmallon@gmail.com>

Ok, looks better. But now you need to udpate all the reverse
dependencies of libsndfile (i.e, all packages that select
BR2_PACKAGE_LIBSNDFILE), to add the same BR2_LARGEFILE dependency. This
concerns bluez_utils, gst-plugins-bad, mpd and pulseaudio.

(Note: this problem should be simplified once we get Yann's work on
the _AVAILABLE thing merged, but in the mean time, we have to handle
those reverse dependencies manually).

Best regards,

Thomas

Patch

diff --git a/package/libsndfile/Config.in b/package/libsndfile/Config.in
index 9afe496..21e1591 100644
--- a/package/libsndfile/Config.in
+++ b/package/libsndfile/Config.in
@@ -1,8 +1,12 @@ 
 config BR2_PACKAGE_LIBSNDFILE
        bool "libsndfile"
+       depends on BR2_LARGEFILE
        help
          Libsndfile is a C library for reading and writing files containing
          sampled sound (such as MS Windows WAV and the Apple/SGI AIFF format)
          through one standard library interface.
 
          http://www.mega-nerd.com/libsndfile/
+
+comment "libsndfile requires a toolchain with LARGEFILE support"
+       depends on !BR2_LARGEFILE