Patchwork libsndfile: select BR2_LARGEFILE

login
register
mail settings
Submitter Ryan Mallon
Date Sept. 17, 2012, 10:41 p.m.
Message ID <5057A716.4070702@gmail.com>
Download mbox | patch
Permalink /patch/184573/
State Changes Requested
Headers show

Comments

Ryan Mallon - Sept. 17, 2012, 10:41 p.m.
libsndfile requires sizeof(sf_count_t) == 8, where sf_count_t is a
typedef alias for off_t. This is not true by default for all
tool-chains, which leads to a runtime assert failure in binaries
compiled against libsndfile. See:
    
  http://permalink.gmane.org/gmane.comp.audio.libsndfile.devel/229
   
Select BR2_LARGEFILE for libsndfile so that sizeof(off_t) == 8.
    
Signed-off-by: Ryan Mallon <rmallon@gmail.com>
---
Thomas Petazzoni - Sept. 18, 2012, 5:02 a.m.
Dear Ryan Mallon,

On Tue, 18 Sep 2012 08:41:26 +1000, Ryan Mallon wrote:
> libsndfile requires sizeof(sf_count_t) == 8, where sf_count_t is a

>  config BR2_PACKAGE_LIBSNDFILE
>         bool "libsndfile"
> +       select BR2_LARGEFILE
>         help
>           Libsndfile is a C library for reading and writing files containing
>           sampled sound (such as MS Windows WAV and the Apple/SGI AIFF format)

No, you shouldn't select BR2_LARGEFILE. You should depend on it. See
package/cdrkit/Config.in for an example. Don't forget to also add the
comment when BR2_LARGEFILE is not available.

Thomas

Patch

diff --git a/package/libsndfile/Config.in b/package/libsndfile/Config.in
index 9afe496..4897ed1 100644
--- a/package/libsndfile/Config.in
+++ b/package/libsndfile/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_LIBSNDFILE
        bool "libsndfile"
+       select BR2_LARGEFILE
        help
          Libsndfile is a C library for reading and writing files containing
          sampled sound (such as MS Windows WAV and the Apple/SGI AIFF format)