Patchwork xtensa: Fix broken build (linker error)

login
register
mail settings
Submitter Stefan Weil
Date Sept. 17, 2012, 8:14 p.m.
Message ID <1347912880-30161-1-git-send-email-sw@weilnetz.de>
Download mbox | patch
Permalink /patch/184531/
State Rejected
Headers show

Comments

Stefan Weil - Sept. 17, 2012, 8:14 p.m.
This configuration requires CONFIG_i8254:

configure --target-list=xtensa-softmmu --audio-card-list=pcspk

Reported-by: Vassili Karpov (malc) <av1474@comtv.ru>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 default-configs/xtensa-softmmu.mak   |    1 +
 default-configs/xtensaeb-softmmu.mak |    1 +
 2 files changed, 2 insertions(+)
Jan Kiszka - Sept. 17, 2012, 9:55 p.m.
On 2012-09-17 22:14, Stefan Weil wrote:
> This configuration requires CONFIG_i8254:
> 
> configure --target-list=xtensa-softmmu --audio-card-list=pcspk

This is wrong. The pcspk "audio card" is registered automatically for
those targets that support it.

> 
> Reported-by: Vassili Karpov (malc) <av1474@comtv.ru>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  default-configs/xtensa-softmmu.mak   |    1 +
>  default-configs/xtensaeb-softmmu.mak |    1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/default-configs/xtensa-softmmu.mak b/default-configs/xtensa-softmmu.mak
> index 9d8899c..c3a263b 100644
> --- a/default-configs/xtensa-softmmu.mak
> +++ b/default-configs/xtensa-softmmu.mak
> @@ -1,5 +1,6 @@
>  # Default configuration for Xtensa
>  
> +CONFIG_I8254=y

And this wrong as well. xtensa does not include any speaker, nor does it
include a PIT.

Jan

>  CONFIG_SERIAL=y
>  CONFIG_OPENCORES_ETH=y
>  CONFIG_PFLASH_CFI01=y
> diff --git a/default-configs/xtensaeb-softmmu.mak b/default-configs/xtensaeb-softmmu.mak
> index 9d8899c..c3a263b 100644
> --- a/default-configs/xtensaeb-softmmu.mak
> +++ b/default-configs/xtensaeb-softmmu.mak
> @@ -1,5 +1,6 @@
>  # Default configuration for Xtensa
>  
> +CONFIG_I8254=y
>  CONFIG_SERIAL=y
>  CONFIG_OPENCORES_ETH=y
>  CONFIG_PFLASH_CFI01=y
>
Anthony Liguori - Sept. 17, 2012, 10:08 p.m.
Jan Kiszka <jan.kiszka@web.de> writes:

> On 2012-09-17 22:14, Stefan Weil wrote:
>> This configuration requires CONFIG_i8254:
>> 
>> configure --target-list=xtensa-softmmu --audio-card-list=pcspk
>
> This is wrong. The pcspk "audio card" is registered automatically for
> those targets that support it.
>
>> 
>> Reported-by: Vassili Karpov (malc) <av1474@comtv.ru>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>>  default-configs/xtensa-softmmu.mak   |    1 +
>>  default-configs/xtensaeb-softmmu.mak |    1 +
>>  2 files changed, 2 insertions(+)
>> 
>> diff --git a/default-configs/xtensa-softmmu.mak b/default-configs/xtensa-softmmu.mak
>> index 9d8899c..c3a263b 100644
>> --- a/default-configs/xtensa-softmmu.mak
>> +++ b/default-configs/xtensa-softmmu.mak
>> @@ -1,5 +1,6 @@
>>  # Default configuration for Xtensa
>>  
>> +CONFIG_I8254=y
>
> And this wrong as well. xtensa does not include any speaker, nor does it
> include a PIT.

I was looking for docs and couldn't find any that indicated it contained
a PIT either.

Regards,

Anthony Liguori

>
> Jan
>
>>  CONFIG_SERIAL=y
>>  CONFIG_OPENCORES_ETH=y
>>  CONFIG_PFLASH_CFI01=y
>> diff --git a/default-configs/xtensaeb-softmmu.mak b/default-configs/xtensaeb-softmmu.mak
>> index 9d8899c..c3a263b 100644
>> --- a/default-configs/xtensaeb-softmmu.mak
>> +++ b/default-configs/xtensaeb-softmmu.mak
>> @@ -1,5 +1,6 @@
>>  # Default configuration for Xtensa
>>  
>> +CONFIG_I8254=y
>>  CONFIG_SERIAL=y
>>  CONFIG_OPENCORES_ETH=y
>>  CONFIG_PFLASH_CFI01=y
>>

Patch

diff --git a/default-configs/xtensa-softmmu.mak b/default-configs/xtensa-softmmu.mak
index 9d8899c..c3a263b 100644
--- a/default-configs/xtensa-softmmu.mak
+++ b/default-configs/xtensa-softmmu.mak
@@ -1,5 +1,6 @@ 
 # Default configuration for Xtensa
 
+CONFIG_I8254=y
 CONFIG_SERIAL=y
 CONFIG_OPENCORES_ETH=y
 CONFIG_PFLASH_CFI01=y
diff --git a/default-configs/xtensaeb-softmmu.mak b/default-configs/xtensaeb-softmmu.mak
index 9d8899c..c3a263b 100644
--- a/default-configs/xtensaeb-softmmu.mak
+++ b/default-configs/xtensaeb-softmmu.mak
@@ -1,5 +1,6 @@ 
 # Default configuration for Xtensa
 
+CONFIG_I8254=y
 CONFIG_SERIAL=y
 CONFIG_OPENCORES_ETH=y
 CONFIG_PFLASH_CFI01=y