Patchwork netxen: check for root bus in netxen_mask_aer_correctable

login
register
mail settings
Submitter Rajesh Borundia
Date Sept. 17, 2012, 5:53 p.m.
Message ID <13A253B3F9BEFE43B93C09CF75F63CAA827E3AE9F9@MNEXMB1.qlogic.org>
Download mbox | patch
Permalink /patch/184520/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Rajesh Borundia - Sept. 17, 2012, 5:53 p.m.

David Miller - Sept. 18, 2012, 8:23 p.m.
No, this is not the correct way to submit patches written by other
people.

Look at how people like Jeff Kirsher submits Intel driver patches
written by people other than himself.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rajesh Borundia - Sept. 19, 2012, 7:24 a.m.

David Miller - Sept. 19, 2012, 5:40 p.m.
From: Rajesh Borundia <rajesh.borundia@qlogic.com>
Date: Wed, 19 Sep 2012 02:24:29 -0500

> 
> ________________________________________
> From: David Miller [davem@davemloft.net]
> Sent: Wednesday, September 19, 2012 1:53 AM
> To: Rajesh Borundia
> Cc: nikolay@redhat.com; Sony Chacko; netdev
> Subject: Re: [PATCH] netxen: check for root bus in netxen_mask_aer_correctable
> 
> No, this is not the correct way to submit patches written by other
> people.
> 
> Look at how people like Jeff Kirsher submits Intel driver patches
> written by people other than himself.
> 
> Apologies, will follow the guideline.

This is also not the correct way to reply to people in email.

You haven't properly quoted me, so it's impossible to discern the text
that I wrote from the text that you have written in response.

If you look at how other people respond in email, you'll see that the
respondee is properly quoted using prefix characters in the initial
columns of the quoted test.

> Like
> this.

This is a function of your email client, please learn how to configure
it so that you can reply properly on these mailing lists.  Don't try
to force it and do the quoting by hand.

It is extremely frustrating to communicate with contributors who
cannot write email that conforms to accepted practices and conventions
on the mailing list.  Please get your act together, or you will find
that your postings will get less attention and care than you would
like.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
index 342b3a7..e2a4858 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
@@ -1378,6 +1378,10 @@  static void netxen_mask_aer_correctable(struct netxen_adapter *adapter)
        struct pci_dev *root = pdev->bus->self;
        u32 aer_pos;

+       /* root bus? */
+       if (!root)
+               return;
+
        if (adapter->ahw.board_type != NETXEN_BRDTYPE_P3_4_GB_MM &&
                adapter->ahw.board_type != NETXEN_BRDTYPE_P3_10G_TP)
                return;