From patchwork Mon Sep 17 13:58:14 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Datta, Shubhrajyoti" X-Patchwork-Id: 184413 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ey0-f184.google.com (mail-ey0-f184.google.com [209.85.215.184]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id EB6AF2C0086 for ; Mon, 17 Sep 2012 23:58:30 +1000 (EST) Received: by eaaa12 with SMTP id a12sf2133149eaa.11 for ; Mon, 17 Sep 2012 06:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-beenthere:received-spf:from:to:cc:subject:date:message-id :x-mailer:in-reply-to:references:mime-version:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=ATr6qKWlmnwVH6aaCBpEPUZCKx3LQgnerBJQF5xx+7o=; b=LR3nZ72c0TGhAfQ+3ON7yFK+WdtFQ67r9/pGbyDVJxeoa+VwxSkPqv8PVmk2VN6v9H iIQs+flDk4sAyBB024pfKPOoqCsHSW/gmlPSP8eCF6JNxvwQRxazzoWZj1uHFWN8C8te dfM2PQQjJOq1ynad7miVv/L4I5Hik3tipjDKeTekLD8lXtQ6fnaNCahLcNnxKlobfWKz xC0NPN1xSqn8y8Tr8fRGSRfxNnPLXj4eJ+O7dakk/QpD258volOap0GPKAudZ89pVN0D S7VcZJiZf6/Zt5o/h0cykEdXcAS52mrnXwfh+Y3NoUMPIkYUUHLWFs2IqRjnaIxCDSJz eTew== Received: by 10.180.106.99 with SMTP id gt3mr977007wib.3.1347890306776; Mon, 17 Sep 2012 06:58:26 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.216.211.133 with SMTP id w5ls8312906weo.8.gmail; Mon, 17 Sep 2012 06:58:25 -0700 (PDT) Received: by 10.216.141.136 with SMTP id g8mr163974wej.1.1347890305610; Mon, 17 Sep 2012 06:58:25 -0700 (PDT) Received: by 10.216.141.136 with SMTP id g8mr163973wej.1.1347890305591; Mon, 17 Sep 2012 06:58:25 -0700 (PDT) Received: from comal.ext.ti.com (comal.ext.ti.com. [198.47.26.152]) by gmr-mx.google.com with ESMTPS id fb20si1880034wid.3.2012.09.17.06.58.25 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 17 Sep 2012 06:58:25 -0700 (PDT) Received-SPF: pass (google.com: domain of shubhrajyoti@ti.com designates 198.47.26.152 as permitted sender) client-ip=198.47.26.152; Received: from dbdp20.itg.ti.com ([172.24.170.38]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id q8HDwMv3010511; Mon, 17 Sep 2012 08:58:23 -0500 Received: from DBDE70.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id q8HDwJiO026484; Mon, 17 Sep 2012 19:28:22 +0530 (IST) Received: from dbdp32.itg.ti.com (172.24.170.251) by dbde70.ent.ti.com (172.24.170.148) with Microsoft SMTP Server id 14.1.323.3; Mon, 17 Sep 2012 19:28:20 +0530 Received: from ula0393217.india.ti.com (smtpvbd.itg.ti.com [172.24.170.250]) by dbdp32.itg.ti.com (8.13.8/8.13.8) with ESMTP id q8HDwGam005802; Mon, 17 Sep 2012 19:28:20 +0530 From: Shubhrajyoti D To: CC: , , Shubhrajyoti D Subject: [rtc-linux] [PATCH 7/7] rtc: Convert struct i2c_msg initialization to C99 format Date: Mon, 17 Sep 2012 19:28:14 +0530 Message-ID: <1347890294-28467-8-git-send-email-shubhrajyoti@ti.com> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1347890294-28467-1-git-send-email-shubhrajyoti@ti.com> References: <1347890294-28467-1-git-send-email-shubhrajyoti@ti.com> MIME-Version: 1.0 X-Original-Sender: shubhrajyoti@ti.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of shubhrajyoti@ti.com designates 198.47.26.152 as permitted sender) smtp.mail=shubhrajyoti@ti.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-x1205.c | 28 ++++++++++++++-------------- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/rtc/rtc-x1205.c b/drivers/rtc/rtc-x1205.c index 403b3d4..4ddd9a6 100644 --- a/drivers/rtc/rtc-x1205.c +++ b/drivers/rtc/rtc-x1205.c @@ -97,8 +97,8 @@ static int x1205_get_datetime(struct i2c_client *client, struct rtc_time *tm, int i; struct i2c_msg msgs[] = { - { client->addr, 0, 2, dt_addr }, /* setup read ptr */ - { client->addr, I2C_M_RD, 8, buf }, /* read date */ + { .addr = client->addr, .flags = 0, .len = 2, .buf = dt_addr }, /* setup read ptr */ + { .addr = client->addr, .flags = I2C_M_RD, .len = 8, .buf = buf }, /* read date */ }; /* read date registers */ @@ -142,8 +142,8 @@ static int x1205_get_status(struct i2c_client *client, unsigned char *sr) static unsigned char sr_addr[2] = { 0, X1205_REG_SR }; struct i2c_msg msgs[] = { - { client->addr, 0, 2, sr_addr }, /* setup read ptr */ - { client->addr, I2C_M_RD, 1, sr }, /* read status */ + { .addr = client->addr, .flags = 0, .len = 2, .buf = sr_addr }, /* setup read ptr */ + { .addr = client->addr, .flags = I2C_M_RD, .len = 1, .buf = sr }, /* read status */ }; /* read status register */ @@ -279,8 +279,8 @@ static int x1205_get_dtrim(struct i2c_client *client, int *trim) static unsigned char dtr_addr[2] = { 0, X1205_REG_DTR }; struct i2c_msg msgs[] = { - { client->addr, 0, 2, dtr_addr }, /* setup read ptr */ - { client->addr, I2C_M_RD, 1, &dtr }, /* read dtr */ + { .addr = client->addr, .flags = 0, .len = 2, .buf = dtr_addr }, /* setup read ptr */ + { .addr = client->addr, .flags = I2C_M_RD, .len = 1, .buf = &dtr }, /* read dtr */ }; /* read dtr register */ @@ -311,8 +311,8 @@ static int x1205_get_atrim(struct i2c_client *client, int *trim) static unsigned char atr_addr[2] = { 0, X1205_REG_ATR }; struct i2c_msg msgs[] = { - { client->addr, 0, 2, atr_addr }, /* setup read ptr */ - { client->addr, I2C_M_RD, 1, &atr }, /* read atr */ + { .addr = client->addr, .flags = 0, .len = 2, .buf = atr_addr }, /* setup read ptr */ + { .addr = client->addr, .flags = I2C_M_RD, .len = 1, .buf = &atr }, /* read atr */ }; /* read atr register */ @@ -381,8 +381,8 @@ static int x1205_validate_client(struct i2c_client *client) unsigned char addr[2] = { 0, probe_zero_pattern[i] }; struct i2c_msg msgs[2] = { - { client->addr, 0, 2, addr }, - { client->addr, I2C_M_RD, 1, &buf }, + { .addr = client->addr, .flags = 0, .len = 2, .buf = addr }, + { .addr = client->addr, .flags = I2C_M_RD, .len = 1, .buf = &buf }, }; if ((xfer = i2c_transfer(client->adapter, msgs, 2)) != 2) { @@ -409,8 +409,8 @@ static int x1205_validate_client(struct i2c_client *client) unsigned char addr[2] = { 0, probe_limits_pattern[i].reg }; struct i2c_msg msgs[2] = { - { client->addr, 0, 2, addr }, - { client->addr, I2C_M_RD, 1, ® }, + { .addr = client->addr, .flags = 0, .len = 2, .buf = addr }, + { .addr = client->addr, .flags = I2C_M_RD, .len = 1, .buf = ® }, }; if ((xfer = i2c_transfer(client->adapter, msgs, 2)) != 2) { @@ -444,8 +444,8 @@ static int x1205_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) static unsigned char int_addr[2] = { 0, X1205_REG_INT }; struct i2c_client *client = to_i2c_client(dev); struct i2c_msg msgs[] = { - { client->addr, 0, 2, int_addr }, /* setup read ptr */ - { client->addr, I2C_M_RD, 1, &intreg }, /* read INT register */ + { .addr = client->addr, .flags = 0, .len = 2, .buf = int_addr }, /* setup read ptr */ + { .addr = client->addr, .flags = I2C_M_RD, .len = 1, .buf = &intreg }, /* read INT register */ }; /* read interrupt register and status register */