From patchwork Mon Sep 17 11:58:29 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [RESEND, v3, 2/5] dt/powerpc/powernv: Use of_get_child_by_name to get a named child. From: Srinivas KANDAGATLA X-Patchwork-Id: 184390 Message-Id: <1347883109-16714-1-git-send-email-srinivas.kandagatla@st.com> To: benh@kernel.crashing.org Cc: kgene.kim@samsung.com, srinivas.kandagatla@st.com, devicetree-discuss@lists.ozlabs.org, broonie@opensource.wolfsonmicro.com, robherring2@gmail.com, ben-linux@fluff.org, linuxppc-dev@lists.ozlabs.org Date: Mon, 17 Sep 2012 12:58:29 +0100 From: Srinivas Kandagatla As follow-up to "dt: introduce of_get_child_by_name to get child node by name." patch, This patch removes some of the code duplication in the driver by replacing it with of_get_child_by_name instead. Signed-off-by: Srinivas Kandagatla --- arch/powerpc/platforms/powernv/opal.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c index aaa0dba..fc7ae70 100644 --- a/arch/powerpc/platforms/powernv/opal.c +++ b/arch/powerpc/platforms/powernv/opal.c @@ -294,9 +294,9 @@ static int __init opal_init(void) consoles = of_node_get(opal_node); /* Register serial ports */ - for_each_child_of_node(consoles, np) { - if (strcmp(np->name, "serial")) - continue; + np = of_get_child_by_name(consoles, "serial"); + if (np) { + of_node_put(np); of_platform_device_create(np, NULL, NULL); } of_node_put(consoles);