Patchwork dts-bindings/fsl/dma.txt: fix IRQ number in mpc83xx dma example

login
register
mail settings
Submitter Peter Korsgaard
Date Jan. 14, 2009, 2:14 p.m.
Message ID <1231942453-17898-1-git-send-email-jacmet@sunsite.dk>
Download mbox | patch
Permalink /patch/18435/
State Superseded
Delegated to: Kumar Gala
Headers show

Comments

Peter Korsgaard - Jan. 14, 2009, 2:14 p.m.
The DMAC IRQ number of the mpc8349 is 71 and not 47, according to
http://www.freescale.com/files/32bit/doc/ref_manual/MPC8349EARMAD.pdf

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
 Documentation/powerpc/dts-bindings/fsl/dma.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Anton Vorontsov - Jan. 14, 2009, 2:21 p.m.
Hi Peter,

On Wed, Jan 14, 2009 at 03:14:13PM +0100, Peter Korsgaard wrote:
> The DMAC IRQ number of the mpc8349 is 71 and not 47, according to
> http://www.freescale.com/files/32bit/doc/ref_manual/MPC8349EARMAD.pdf
> 
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
> ---
>  Documentation/powerpc/dts-bindings/fsl/dma.txt |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/powerpc/dts-bindings/fsl/dma.txt b/Documentation/powerpc/dts-bindings/fsl/dma.txt
> index cc45311..3df1552 100644
> --- a/Documentation/powerpc/dts-bindings/fsl/dma.txt
> +++ b/Documentation/powerpc/dts-bindings/fsl/dma.txt
> @@ -38,7 +38,7 @@ Example:
>  		reg = <82a8 4>;
>  		ranges = <0 8100 1a4>;
>  		interrupt-parent = <&ipic>;
> -		interrupts = <47 8>;
> +		interrupts = <71 8>;

0x47 = 71 ;-) The example is in the dts-v0 format, all the numbers
are hexadecimal.
Kumar Gala - Jan. 14, 2009, 2:35 p.m.
On Jan 14, 2009, at 8:21 AM, Anton Vorontsov wrote:

> Hi Peter,
>
> On Wed, Jan 14, 2009 at 03:14:13PM +0100, Peter Korsgaard wrote:
>> The DMAC IRQ number of the mpc8349 is 71 and not 47, according to
>> http://www.freescale.com/files/32bit/doc/ref_manual/MPC8349EARMAD.pdf
>>
>> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
>> ---
>> Documentation/powerpc/dts-bindings/fsl/dma.txt |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/Documentation/powerpc/dts-bindings/fsl/dma.txt b/ 
>> Documentation/powerpc/dts-bindings/fsl/dma.txt
>> index cc45311..3df1552 100644
>> --- a/Documentation/powerpc/dts-bindings/fsl/dma.txt
>> +++ b/Documentation/powerpc/dts-bindings/fsl/dma.txt
>> @@ -38,7 +38,7 @@ Example:
>> 		reg = <82a8 4>;
>> 		ranges = <0 8100 1a4>;
>> 		interrupt-parent = <&ipic>;
>> -		interrupts = <47 8>;
>> +		interrupts = <71 8>;
>
> 0x47 = 71 ;-) The example is in the dts-v0 format, all the numbers
> are hexadecimal.

I'm all for changing the docs to dts-v1 syntax but if you are going to  
do that.  Do it completely for the file.

(reg, ranges, etc..)

- k
Peter Korsgaard - Jan. 14, 2009, 2:47 p.m.
>>>>> "Anton" == Anton Vorontsov <avorontsov@ru.mvista.com> writes:

Hi,

 >> interrupt-parent = <&ipic>;
 >> -		interrupts = <47 8>;
 >> +		interrupts = <71 8>;

 Anton> 0x47 = 71 ;-) The example is in the dts-v0 format, all the numbers
 Anton> are hexadecimal.

Ahh ;)

Patch

diff --git a/Documentation/powerpc/dts-bindings/fsl/dma.txt b/Documentation/powerpc/dts-bindings/fsl/dma.txt
index cc45311..3df1552 100644
--- a/Documentation/powerpc/dts-bindings/fsl/dma.txt
+++ b/Documentation/powerpc/dts-bindings/fsl/dma.txt
@@ -38,7 +38,7 @@  Example:
 		reg = <82a8 4>;
 		ranges = <0 8100 1a4>;
 		interrupt-parent = <&ipic>;
-		interrupts = <47 8>;
+		interrupts = <71 8>;
 		cell-index = <0>;
 		dma-channel@0 {
 			compatible = "fsl,mpc8349-dma-channel", "fsl,elo-dma-channel";