Patchwork [v3,3/5] dt/powerpc/sysdev: Use of_get_child_by_name to get a named child.

login
register
mail settings
Submitter Srinivas KANDAGATLA
Date Sept. 17, 2012, 8:57 a.m.
Message ID <1347872272-3741-1-git-send-email-srinivas.kandagatla@st.com>
Download mbox | patch
Permalink /patch/184331/
State Superseded
Headers show

Comments

Srinivas KANDAGATLA - Sept. 17, 2012, 8:57 a.m.
From: Srinivas Kandagatla <srinivas.kandagatla@st.com>

As follow-up to "dt: introduce of_get_child_by_name to get child node by
name." patch, This patch removes some of the code duplication in the
driver by replacing it with of_get_child_by_name instead.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
---
 arch/powerpc/sysdev/qe_lib/qe.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

Patch

diff --git a/arch/powerpc/sysdev/qe_lib/qe.c b/arch/powerpc/sysdev/qe_lib/qe.c
index b043675..d094e51 100644
--- a/arch/powerpc/sysdev/qe_lib/qe.c
+++ b/arch/powerpc/sysdev/qe_lib/qe.c
@@ -568,10 +568,7 @@  struct qe_firmware_info *qe_get_firmware_info(void)
 	}
 
 	/* Find the 'firmware' child node */
-	for_each_child_of_node(qe, fw) {
-		if (strcmp(fw->name, "firmware") == 0)
-			break;
-	}
+	fw = of_get_child_by_name(qe, "firmware");
 
 	of_node_put(qe);