From patchwork Mon Sep 17 07:29:34 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [net-next] mlx4: use dev_kfree_skb() instead of dev_kfree_skb_any() Date: Sun, 16 Sep 2012 21:29:34 -0000 From: Eric Dumazet X-Patchwork-Id: 184314 Message-Id: <1347866974.26523.53.camel@edumazet-glaptop> To: David Miller Cc: netdev , Yevgeny Petrilin , Or Gerlitz , Ying Cai From: Eric Dumazet Since commit e22979d96a5 (mlx4_en: Moving to Interrupts for TX completions), we no longer can free TX skb from hard IRQ, but only from normal softirq or process context. Therefore, we can directly call dev_kfree_skb() from mlx4_en_free_tx_desc() like other conventional NAPI drivers. Signed-off-by: Eric Dumazet Cc: Yevgeny Petrilin Cc: Or Gerlitz Cc: Ying Cai --- drivers/net/ethernet/mellanox/mlx4/en_tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c index 10bba09..e182762 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c @@ -266,7 +266,7 @@ static u32 mlx4_en_free_tx_desc(struct mlx4_en_priv *priv, } } - dev_kfree_skb_any(skb); + dev_kfree_skb(skb); return tx_info->nr_txbb; }