From patchwork Sun Sep 16 10:12:13 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mikael Morin X-Patchwork-Id: 184121 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id B4CA22C0093 for ; Sun, 16 Sep 2012 20:15:35 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1348395336; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=0ndAMIcwGXK0CVAtsEhLKAg0GDw=; b=OD7m4XrNOltHFSw sjRKhli8u7WCN3zwn8wSiLufMmJwDjOoj30nJEvmFGOlpaRJfB9F6kh7HUjz+8oL lUAu7iksFdu15R8PP0ky+yGLAmtsCWDkImHbeLpTH8n5iqv9I+Byr8njZ7yegi8l EIqSL4oAd+ISSGCbVxViRO5WIQBo= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:X-SFR-UUID:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=NhTG9wWEEb509XrdZOHiwYA6Z2dVj0rnw0MK/9hsFqltvk/teLxz9IzyBRu8ka Ey8cwhtN4znnY9/HqNvVrVBzUU9bigW51tK8/pHpe2hsHcZ0/21cx2j0p9c6H9N7 iUR0TKe1HVveJf+06upWBjPQmaFixUVAyJgPNpvM80h4o=; Received: (qmail 7895 invoked by alias); 16 Sep 2012 10:15:29 -0000 Received: (qmail 7877 invoked by uid 22791); 16 Sep 2012 10:15:28 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL, BAYES_00, KHOP_THREADED, RCVD_IN_DNSWL_NONE, RCVD_IN_HOSTKARMA_NO, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp24.services.sfr.fr (HELO smtp24.services.sfr.fr) (93.17.128.83) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 16 Sep 2012 10:15:14 +0000 Received: from filter.sfr.fr (localhost [127.0.0.1]) by msfrf2411.sfr.fr (SMTP Server) with ESMTP id 4F1A3700004F; Sun, 16 Sep 2012 12:15:13 +0200 (CEST) Received: from [192.168.1.58] (165.183.72.86.rev.sfr.net [86.72.183.165]) by msfrf2411.sfr.fr (SMTP Server) with ESMTP id D040F7000043; Sun, 16 Sep 2012 12:15:12 +0200 (CEST) X-SFR-UUID: 20120916101512853.D040F7000043@msfrf2411.sfr.fr Message-ID: <5055A5FD.5040005@sfr.fr> Date: Sun, 16 Sep 2012 12:12:13 +0200 From: Mikael Morin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.7) Gecko/20120910 Thunderbird/10.0.7 MIME-Version: 1.0 To: Tobias Burnus CC: gcc patches , gfortran Subject: Re: [Patch, Fortran] Fix some issues found by Coverity's static-code analysis scan References: <50544E8A.5040704@net-b.de> <50549E90.7000204@sfr.fr> <5054BC84.7040203@net-b.de> In-Reply-To: <5054BC84.7040203@net-b.de> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 15/09/2012 19:36, Tobias Burnus wrote: > Hi Mikael, > > thanks for your comments. > > As a pre-script: Will you look at Paul's revised assignment patch - or > should I do it? I looked at it twice or so, and couldn't get the double temporary thing. I'll get back to it. > If you want to know the Coverity's diagnostic, you can also have access > to GCC's Coverity scan results. Are you interested? I have no plans to make anything out of them in the foreseeable future; for later I don't know, why not. > Thanks for the analysis. Will you create a patch? > Attached. Tested against "*namelist*" and full regression test in progress. OK? Mikael 2012-09-16 Mikael Morin * symbol.c (gfc_undo_symbols): Correctly undo namelists. 2012-09-16 Mikael Morin * gfortran.dg/namelist_75.f90: New test. Index: symbol.c =================================================================== --- symbol.c (révision 191341) +++ symbol.c (copie de travail) @@ -2996,7 +2996,7 @@ gfc_undo_symbols (void) { if (p->namelist_tail != old->namelist_tail) { - gfc_free_namelist (old->namelist_tail); + gfc_free_namelist (old->namelist_tail->next); old->namelist_tail->next = NULL; } }