Message ID | CANEcBPQnsV26UkyGxms0vKM9wK1NxfKjN4Z0qGipQtV4UPZgGA@mail.gmail.com |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
On Sun, Sep 16, 2012 at 10:30 AM, Xiaodong Xu <stid.smth@gmail.com> wrote: > Hi All, > > I found a bug in kernel PPPOE driver. > When PPPOE is running over a virtual ethernet interface (e.g., a > bonding interface) and the user tries to delete the interface in case > the PPPOE state is ZOMBIE, the kernel will loop infinitely while > unregistering net_device for the reference count is not reset to zero > which should be done by dev_put(). > > The following patch could fix this issue: You missed your Signed-off-by, please read Documentation/SubmittingPatches and check your patch with scripts/checkpatch.pl before sending. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Xiaodong Xu <stid.smth@gmail.com> Date: Sun, 16 Sep 2012 10:30:53 +0800 > Hi All, > > I found a bug in kernel PPPOE driver. > When PPPOE is running over a virtual ethernet interface (e.g., a > bonding interface) and the user tries to delete the interface in case > the PPPOE state is ZOMBIE, the kernel will loop infinitely while > unregistering net_device for the reference count is not reset to zero > which should be done by dev_put(). > > The following patch could fix this issue: > > $ git diff Please read Documentation/SubmittingPatches in the kernel source tree to learn how to properly submit a patch. In particular your patch was missing a proper signoff and your Subject line is incorrectly specified. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c index cbf7047..20f31d0 100644 --- a/drivers/net/ppp/pppoe.c +++ b/drivers/net/ppp/pppoe.c @@ -570,7 +570,7 @@ static int pppoe_release(struct socket *sock) po = pppox_sk(sk); - if (sk->sk_state & (PPPOX_CONNECTED | PPPOX_BOUND)) { + if (sk->sk_state & (PPPOX_CONNECTED | PPPOX_BOUND | PPPOX_ZOMBIE)) { dev_put(po->pppoe_dev); po->pppoe_dev = NULL; }