From patchwork Sat Sep 15 19:26:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [v2] mtd: nand: docg4: ecc.read_page() returns 0 on uncorrectable errors From: Mike Dunn X-Patchwork-Id: 184097 Message-Id: <1347737205-17019-1-git-send-email-mikedunn@newsguy.com> To: linux-mtd@lists.infradead.org Cc: computersforpeace@gmail.com, Mike Dunn Date: Sat, 15 Sep 2012 12:26:45 -0700 v2 fixes spelling error Currently the docg4's ecc.read_page() method returns -EBADMSG when uncorrectible bitflips occur. This is wrong; 0 should be returned in this case. An error code should only be returned by this method in the case of a hardware error (probably -EIO). Signed-off-by: Mike Dunn Acked-by: Brian Norris --- drivers/mtd/nand/docg4.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/nand/docg4.c b/drivers/mtd/nand/docg4.c index 793921e..deb718c 100644 --- a/drivers/mtd/nand/docg4.c +++ b/drivers/mtd/nand/docg4.c @@ -776,6 +776,8 @@ static int read_page(struct mtd_info *mtd, struct nand_chip *nand, } writew(0, docptr + DOC_DATAEND); + if (bits_corrected == -EBADMSG) /* uncorrectable errors */ + return 0; return bits_corrected; }