Patchwork [U-Boot,v4,2/2] ARM: kirkwood/orion5x: Use reset_cpu definition in include/common.h

login
register
mail settings
Submitter dinguyen@altera.com
Date Sept. 14, 2012, 9:08 p.m.
Message ID <1347656908-31420-2-git-send-email-dinguyen@altera.com>
Download mbox | patch
Permalink /patch/184033/
State Accepted
Headers show

Comments

dinguyen@altera.com - Sept. 14, 2012, 9:08 p.m.
From: Dinh Nguyen <dinguyen@altera.com>

include/common.h has the reset_cpu defined already. No need to
re-define here.

Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
Signed-off-by: Pavel Machek <pavel@denx.de>
---
 arch/arm/include/asm/arch-kirkwood/cpu.h |    1 -
 arch/arm/include/asm/arch-orion5x/cpu.h  |    1 -
 2 files changed, 2 deletions(-)
Prafulla Wadaskar - Sept. 14, 2012, 10:25 p.m.
> -----Original Message-----
> From: u-boot-bounces@lists.denx.de [mailto:u-boot-
> bounces@lists.denx.de] On Behalf Of dinguyen@altera.com
> Sent: 14 September 2012 14:08
> To: u-boot@lists.denx.de
> Cc: marex@denx.de; dinh.linux@gmail.com; pavel@denx.de;
> clsee@altera.com; trini@ti.com; sr@denx.de
> Subject: [U-Boot] [PATCH v4 2/2] ARM: kirkwood/orion5x: Use reset_cpu
> definition in include/common.h
> 
> From: Dinh Nguyen <dinguyen@altera.com>
> 
> include/common.h has the reset_cpu defined already. No need to
> re-define here.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> Signed-off-by: Pavel Machek <pavel@denx.de>
> ---
>  arch/arm/include/asm/arch-kirkwood/cpu.h |    1 -
>  arch/arm/include/asm/arch-orion5x/cpu.h  |    1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/arch/arm/include/asm/arch-kirkwood/cpu.h
> b/arch/arm/include/asm/arch-kirkwood/cpu.h
> index d28c51a..7a53c8f 100644
> --- a/arch/arm/include/asm/arch-kirkwood/cpu.h
> +++ b/arch/arm/include/asm/arch-kirkwood/cpu.h
> @@ -155,7 +155,6 @@ struct kwgpio_registers {
>  /*
>   * functions
>   */
> -void reset_cpu(unsigned long ignored);
>  unsigned char get_random_hex(void);
>  unsigned int kw_sdram_bar(enum memory_bank bank);
>  unsigned int kw_sdram_bs(enum memory_bank bank);
> diff --git a/arch/arm/include/asm/arch-orion5x/cpu.h
> b/arch/arm/include/asm/arch-orion5x/cpu.h
> index 2f52ca8..17b9b69 100644
> --- a/arch/arm/include/asm/arch-orion5x/cpu.h
> +++ b/arch/arm/include/asm/arch-orion5x/cpu.h
> @@ -251,7 +251,6 @@ struct orion5x_ddr_addr_decode_registers {
>  /*
>   * functions
>   */
> -void reset_cpu(unsigned long ignored);
>  u32 orion5x_device_id(void);
>  u32 orion5x_device_rev(void);
>  unsigned int orion5x_winctrl_calcsize(unsigned int sizeval);
> --

Acked-By: Prafulla Wadaskar <Prafulla@marvell.com>

BTW: you could have made this patch independent so that it could be pulled independently.

Regards...
Prafulla . . .
Pavel Machek - Sept. 15, 2012, 9:14 p.m.
Hi!

> > From: Dinh Nguyen <dinguyen@altera.com>
> > 
> > include/common.h has the reset_cpu defined already. No need to
> > re-define here.
> > 
> > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > Signed-off-by: Pavel Machek <pavel@denx.de>
> > ---
> >  arch/arm/include/asm/arch-kirkwood/cpu.h |    1 -
> >  arch/arm/include/asm/arch-orion5x/cpu.h  |    1 -
> >  2 files changed, 2 deletions(-)
> > 
> > diff --git a/arch/arm/include/asm/arch-kirkwood/cpu.h
> > b/arch/arm/include/asm/arch-kirkwood/cpu.h
> > index d28c51a..7a53c8f 100644
> > --- a/arch/arm/include/asm/arch-kirkwood/cpu.h
> > +++ b/arch/arm/include/asm/arch-kirkwood/cpu.h
> > @@ -155,7 +155,6 @@ struct kwgpio_registers {
> >  /*
> >   * functions
> >   */
> > -void reset_cpu(unsigned long ignored);
> >  unsigned char get_random_hex(void);
> >  unsigned int kw_sdram_bar(enum memory_bank bank);
> >  unsigned int kw_sdram_bs(enum memory_bank bank);
> > diff --git a/arch/arm/include/asm/arch-orion5x/cpu.h
> > b/arch/arm/include/asm/arch-orion5x/cpu.h
> > index 2f52ca8..17b9b69 100644
> > --- a/arch/arm/include/asm/arch-orion5x/cpu.h
> > +++ b/arch/arm/include/asm/arch-orion5x/cpu.h
> > @@ -251,7 +251,6 @@ struct orion5x_ddr_addr_decode_registers {
> >  /*
> >   * functions
> >   */
> > -void reset_cpu(unsigned long ignored);
> >  u32 orion5x_device_id(void);
> >  u32 orion5x_device_rev(void);
> >  unsigned int orion5x_winctrl_calcsize(unsigned int sizeval);
> > --
> 
> Acked-By: Prafulla Wadaskar <Prafulla@marvell.com>
> 
> BTW: you could have made this patch independent so that it could be pulled independently.

It is independend... Feel free to just apply it.

									Pavel
Prafulla Wadaskar - Sept. 19, 2012, 8:44 p.m.
> -----Original Message-----
> From: Pavel Machek [mailto:pavel@denx.de]
> Sent: 16 September 2012 02:44
> To: Prafulla Wadaskar
> Cc: dinguyen@altera.com; u-boot@lists.denx.de; marex@denx.de;
> dinh.linux@gmail.com; clsee@altera.com; trini@ti.com; sr@denx.de
> Subject: Re: [U-Boot] [PATCH v4 2/2] ARM: kirkwood/orion5x: Use
> reset_cpu definition in include/common.h
> 
> Hi!
> 
> > > From: Dinh Nguyen <dinguyen@altera.com>
> > >
> > > include/common.h has the reset_cpu defined already. No need to
> > > re-define here.
> > >
> > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > > Signed-off-by: Pavel Machek <pavel@denx.de>
> > > ---
> > >  arch/arm/include/asm/arch-kirkwood/cpu.h |    1 -
> > >  arch/arm/include/asm/arch-orion5x/cpu.h  |    1 -
> > >  2 files changed, 2 deletions(-)
> > >
> > > diff --git a/arch/arm/include/asm/arch-kirkwood/cpu.h
> > > b/arch/arm/include/asm/arch-kirkwood/cpu.h
> > > index d28c51a..7a53c8f 100644
> > > --- a/arch/arm/include/asm/arch-kirkwood/cpu.h
> > > +++ b/arch/arm/include/asm/arch-kirkwood/cpu.h
> > > @@ -155,7 +155,6 @@ struct kwgpio_registers {
> > >  /*
> > >   * functions
> > >   */
> > > -void reset_cpu(unsigned long ignored);
> > >  unsigned char get_random_hex(void);
> > >  unsigned int kw_sdram_bar(enum memory_bank bank);
> > >  unsigned int kw_sdram_bs(enum memory_bank bank);
> > > diff --git a/arch/arm/include/asm/arch-orion5x/cpu.h
> > > b/arch/arm/include/asm/arch-orion5x/cpu.h
> > > index 2f52ca8..17b9b69 100644
> > > --- a/arch/arm/include/asm/arch-orion5x/cpu.h
> > > +++ b/arch/arm/include/asm/arch-orion5x/cpu.h
> > > @@ -251,7 +251,6 @@ struct orion5x_ddr_addr_decode_registers {
> > >  /*
> > >   * functions
> > >   */
> > > -void reset_cpu(unsigned long ignored);
> > >  u32 orion5x_device_id(void);
> > >  u32 orion5x_device_rev(void);
> > >  unsigned int orion5x_winctrl_calcsize(unsigned int sizeval);
> > > --
> >
> > Acked-By: Prafulla Wadaskar <Prafulla@marvell.com>
> >
> > BTW: you could have made this patch independent so that it could be
> pulled independently.
> 
> It is independend... Feel free to just apply it.

Subject [U-Boot] [PATCH v4 2/2] indicates it as a part of patch series. It is confusing to pull just one patch out of any patch series.

It would be good if you can post it as standalone patch for better understanding by others on the mailing list.

This is a process issue, there is no technical issue with this patch :-)

Regards...
Prafulla . . .
Pavel Machek - Sept. 25, 2012, 12:27 p.m.
Albert, could you apply this?

It is trivial cleanup, and while marked 2/2, it is really independend.

Thanks,
									Pavel

On Fri 2012-09-14 15:08:28, dinguyen@altera.com wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
> 
> include/common.h has the reset_cpu defined already. No need to
> re-define here.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> Signed-off-by: Pavel Machek <pavel@denx.de>
> ---
>  arch/arm/include/asm/arch-kirkwood/cpu.h |    1 -
>  arch/arm/include/asm/arch-orion5x/cpu.h  |    1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/arch/arm/include/asm/arch-kirkwood/cpu.h b/arch/arm/include/asm/arch-kirkwood/cpu.h
> index d28c51a..7a53c8f 100644
> --- a/arch/arm/include/asm/arch-kirkwood/cpu.h
> +++ b/arch/arm/include/asm/arch-kirkwood/cpu.h
> @@ -155,7 +155,6 @@ struct kwgpio_registers {
>  /*
>   * functions
>   */
> -void reset_cpu(unsigned long ignored);
>  unsigned char get_random_hex(void);
>  unsigned int kw_sdram_bar(enum memory_bank bank);
>  unsigned int kw_sdram_bs(enum memory_bank bank);
> diff --git a/arch/arm/include/asm/arch-orion5x/cpu.h b/arch/arm/include/asm/arch-orion5x/cpu.h
> index 2f52ca8..17b9b69 100644
> --- a/arch/arm/include/asm/arch-orion5x/cpu.h
> +++ b/arch/arm/include/asm/arch-orion5x/cpu.h
> @@ -251,7 +251,6 @@ struct orion5x_ddr_addr_decode_registers {
>  /*
>   * functions
>   */
> -void reset_cpu(unsigned long ignored);
>  u32 orion5x_device_id(void);
>  u32 orion5x_device_rev(void);
>  unsigned int orion5x_winctrl_calcsize(unsigned int sizeval);
Prafulla Wadaskar - Sept. 26, 2012, 7:38 a.m.
> -----Original Message-----
> From: u-boot-bounces@lists.denx.de [mailto:u-boot-
> bounces@lists.denx.de] On Behalf Of Pavel Machek
> Sent: 25 September 2012 17:57
> To: dinguyen@altera.com
> Cc: marex@denx.de; dinh.linux@gmail.com; clsee@altera.com; u-
> boot@lists.denx.de; trini@ti.com; sr@denx.de
> Subject: Re: [U-Boot] [PATCH v4 2/2] ARM: kirkwood/orion5x: Use
> reset_cpu definition in include/common.h
> 
> Albert, could you apply this?
> 
> It is trivial cleanup, and while marked 2/2, it is really independend.
> 
> Thanks,

Hi Pavel

I should suppose to pull this patch :-)
I will pull it on u-boot-marvell.git
You take care of other patch independency posted in this patch series.

AND, Please avoid top posting.

Regards...
Prafulla . . .


> 									Pavel
> 
> On Fri 2012-09-14 15:08:28, dinguyen@altera.com wrote:
> > From: Dinh Nguyen <dinguyen@altera.com>
> >
> > include/common.h has the reset_cpu defined already. No need to
> > re-define here.
> >
> > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > Signed-off-by: Pavel Machek <pavel@denx.de>
> > ---
> >  arch/arm/include/asm/arch-kirkwood/cpu.h |    1 -
> >  arch/arm/include/asm/arch-orion5x/cpu.h  |    1 -
> >  2 files changed, 2 deletions(-)
> >
> > diff --git a/arch/arm/include/asm/arch-kirkwood/cpu.h
> b/arch/arm/include/asm/arch-kirkwood/cpu.h
> > index d28c51a..7a53c8f 100644
> > --- a/arch/arm/include/asm/arch-kirkwood/cpu.h
> > +++ b/arch/arm/include/asm/arch-kirkwood/cpu.h
> > @@ -155,7 +155,6 @@ struct kwgpio_registers {
> >  /*
> >   * functions
> >   */
> > -void reset_cpu(unsigned long ignored);
> >  unsigned char get_random_hex(void);
> >  unsigned int kw_sdram_bar(enum memory_bank bank);
> >  unsigned int kw_sdram_bs(enum memory_bank bank);
> > diff --git a/arch/arm/include/asm/arch-orion5x/cpu.h
> b/arch/arm/include/asm/arch-orion5x/cpu.h
> > index 2f52ca8..17b9b69 100644
> > --- a/arch/arm/include/asm/arch-orion5x/cpu.h
> > +++ b/arch/arm/include/asm/arch-orion5x/cpu.h
> > @@ -251,7 +251,6 @@ struct orion5x_ddr_addr_decode_registers {
> >  /*
> >   * functions
> >   */
> > -void reset_cpu(unsigned long ignored);
> >  u32 orion5x_device_id(void);
> >  u32 orion5x_device_rev(void);
> >  unsigned int orion5x_winctrl_calcsize(unsigned int sizeval);
> 
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures)
> http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Prafulla Wadaskar - Sept. 28, 2012, 6:21 a.m.
> -----Original Message-----
> From: u-boot-bounces@lists.denx.de [mailto:u-boot-
> bounces@lists.denx.de] On Behalf Of Pavel Machek
> Sent: 25 September 2012 17:57
> To: dinguyen@altera.com
> Cc: marex@denx.de; dinh.linux@gmail.com; clsee@altera.com; u-
> boot@lists.denx.de; trini@ti.com; sr@denx.de
> Subject: Re: [U-Boot] [PATCH v4 2/2] ARM: kirkwood/orion5x: Use
> reset_cpu definition in include/common.h
> 
> Albert, could you apply this?
> 
> It is trivial cleanup, and while marked 2/2, it is really independend.

Applied to u-boot-marvell.git master branch

Regards...
Prafulla . . .
Pavel Machek - Sept. 28, 2012, 9:52 a.m.
> > Albert, could you apply this?
> > 
> > It is trivial cleanup, and while marked 2/2, it is really independend.
> 
> Applied to u-boot-marvell.git master branch

Thanks!
									Pavel

Patch

diff --git a/arch/arm/include/asm/arch-kirkwood/cpu.h b/arch/arm/include/asm/arch-kirkwood/cpu.h
index d28c51a..7a53c8f 100644
--- a/arch/arm/include/asm/arch-kirkwood/cpu.h
+++ b/arch/arm/include/asm/arch-kirkwood/cpu.h
@@ -155,7 +155,6 @@  struct kwgpio_registers {
 /*
  * functions
  */
-void reset_cpu(unsigned long ignored);
 unsigned char get_random_hex(void);
 unsigned int kw_sdram_bar(enum memory_bank bank);
 unsigned int kw_sdram_bs(enum memory_bank bank);
diff --git a/arch/arm/include/asm/arch-orion5x/cpu.h b/arch/arm/include/asm/arch-orion5x/cpu.h
index 2f52ca8..17b9b69 100644
--- a/arch/arm/include/asm/arch-orion5x/cpu.h
+++ b/arch/arm/include/asm/arch-orion5x/cpu.h
@@ -251,7 +251,6 @@  struct orion5x_ddr_addr_decode_registers {
 /*
  * functions
  */
-void reset_cpu(unsigned long ignored);
 u32 orion5x_device_id(void);
 u32 orion5x_device_rev(void);
 unsigned int orion5x_winctrl_calcsize(unsigned int sizeval);