Patchwork Revert "Add ability to disable build of all targets"

login
register
mail settings
Submitter Anthony Liguori
Date Sept. 14, 2012, 1:20 p.m.
Message ID <1347628849-4922-1-git-send-email-aliguori@us.ibm.com>
Download mbox | patch
Permalink /patch/183926/
State New
Headers show

Comments

Anthony Liguori - Sept. 14, 2012, 1:20 p.m.
This reverts commit 66d5499b3754b83c09487259c08fe2ce73188a59.

This commit broke --target-list="x86_64-softmmu" and the fix isn't immediatley
obvious.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
 configure |   13 +++++++++----
 1 files changed, 9 insertions(+), 4 deletions(-)
Peter Maydell - Sept. 14, 2012, 1:24 p.m.
On 14 September 2012 14:20, Anthony Liguori <aliguori@us.ibm.com> wrote:
> This reverts commit 66d5499b3754b83c09487259c08fe2ce73188a59.
>
> This commit broke --target-list="x86_64-softmmu"

Actually that still works fine. What doesn't work is passing
several comma-specified target names to --target-list.

> and the fix isn't immediatley obvious.

"immediately" (since I'm here anyway).

Agreed that reverting is the right thing to do.

-- PMM

Patch

diff --git a/configure b/configure
index 7656c32..138f045 100755
--- a/configure
+++ b/configure
@@ -127,7 +127,7 @@  cc_i386=i386-pc-linux-gnu-gcc
 libs_qga=""
 debug_info="yes"
 
-target_list="DEFAULT"
+target_list=""
 
 # Default value for a variable defining feature "foo".
 #  * foo="no"  feature will only be used if --enable-foo arg is given
@@ -1322,10 +1322,15 @@  if ! "$python" -c 'import sys; sys.exit(sys.version_info < (2,4) or sys.version_
   exit 1
 fi
 
-if test "$target_list" = "DEFAULT" ; then
-    target_list=`echo "$default_target_list" | sed -e 's/,/ /g'`
+if test -z "$target_list" ; then
+    target_list="$default_target_list"
+else
+    target_list=`echo "$target_list" | sed -e 's/,/ /g'`
+fi
+if test -z "$target_list" ; then
+    echo "No targets enabled"
+    exit 1
 fi
-
 # see if system emulation was really requested
 case " $target_list " in
   *"-softmmu "*) softmmu=yes