From patchwork Fri Sep 14 09:31:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anatolij Gustschin X-Patchwork-Id: 183856 X-Patchwork-Delegate: agust@denx.de Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [IPv6:::1]) by ozlabs.org (Postfix) with ESMTP id B10642C018E for ; Fri, 14 Sep 2012 19:31:45 +1000 (EST) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BB9852C0085 for ; Fri, 14 Sep 2012 19:31:19 +1000 (EST) Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3XJBLV1tH1z3hhqV; Fri, 14 Sep 2012 11:31:14 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3XJBLV0MNCzbbgl; Fri, 14 Sep 2012 11:31:14 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id 1zd-+NGfiLya; Fri, 14 Sep 2012 11:31:01 +0200 (CEST) X-Auth-Info: vgPTuOWgTkT6yWYDW7VpRUCVfFdCaUh2DpNZUmGQOq8= Received: from webmail.mnet-online.de (webmail1.mnet-online.de [212.18.5.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 14 Sep 2012 11:31:00 +0200 (CEST) Received: from pD9E16F73.dip.t-dialin.net (pD9E16F73.dip.t-dialin.net [217.225.111.115]) by webmail.mnet-online.de (Horde Framework) with HTTP; Fri, 14 Sep 2012 11:31:00 +0200 Message-ID: <20120914113100.119048xeot7zcym8@webmail.mnet-online.de> Date: Fri, 14 Sep 2012 11:31:00 +0200 From: agust@denx.de To: Eric Millbrandt Subject: Re: [PATCH 1/7] powerpc/52xx: define FSL_SOC References: <1347572596-37540-1-git-send-email-emillbrandt@dekaresearch.com> <1347572596-37540-2-git-send-email-emillbrandt@dekaresearch.com> In-Reply-To: <1347572596-37540-2-git-send-email-emillbrandt@dekaresearch.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Internet Messaging Program (IMP) H3 (4.3.5) Cc: alsa-devel@alsa-project.org, Mark Brown , linuxppc-dev@lists.ozlabs.org, Liam Girdwood X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Eric Millbrandt wrote: > mpc52xx socs need to have FSL_SOC defined to build their drivers > (i2c-mpc, ASoC) No, i2c-mpc depends on PPC only. And FSL_SOC enables code we do not use on mpc52xx. For ASoC please see comment below. > Signed-off-by: Eric Millbrandt > > diff --git a/arch/powerpc/platforms/52xx/Kconfig > b/arch/powerpc/platforms/52xx/Kconfig > index 90f4496..fb35944 100644 > --- a/arch/powerpc/platforms/52xx/Kconfig > +++ b/arch/powerpc/platforms/52xx/Kconfig > @@ -1,6 +1,7 @@ > config PPC_MPC52xx > bool "52xx-based boards" > depends on 6xx > + select FSL_SOC Better use: Thanks, Anatolij diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index d701330..4563b28 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -6,7 +6,7 @@ config SND_SOC_FSL_UTILS menuconfig SND_POWERPC_SOC tristate "SoC Audio for Freescale PowerPC CPUs" - depends on FSL_SOC + depends on FSL_SOC || PPC_MPC52xx help Say Y or M if you want to add support for codecs attached to the PowerPC CPUs.