Patchwork [04/13] powerpc/ps3: clear_bit/set_bit operate on unsigned longs

login
register
mail settings
Submitter Stephen Rothwell
Date Jan. 14, 2009, 6 a.m.
Message ID <20090114170029.702de0cd.sfr@canb.auug.org.au>
Download mbox | patch
Permalink /patch/18365/
State Not Applicable
Delegated to: Jeremy Kerr
Headers show

Comments

Stephen Rothwell - Jan. 14, 2009, 6 a.m.
This fixes these compiler warning:

arch/powerpc/platforms/ps3/interrupt.c:109: warning: passing argument 2 of 'clear_bit' from incompatible pointer type
arch/powerpc/platforms/ps3/interrupt.c:130: warning: passing argument 2 of 'set_bit' from incompatible pointer type

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/powerpc/platforms/ps3/interrupt.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
Geoff Levand - Jan. 14, 2009, 10:53 p.m.
Stephen Rothwell wrote:
> This fixes these compiler warning:
> 
> arch/powerpc/platforms/ps3/interrupt.c:109: warning: passing argument 2 of 'clear_bit' from incompatible pointer type
> arch/powerpc/platforms/ps3/interrupt.c:130: warning: passing argument 2 of 'set_bit' from incompatible pointer type
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  arch/powerpc/platforms/ps3/interrupt.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)

Acked-by: Geoff Levand <geoffrey.levand@am.sony.com>

Patch

diff --git a/arch/powerpc/platforms/ps3/interrupt.c b/arch/powerpc/platforms/ps3/interrupt.c
index b746792..3ea6e51 100644
--- a/arch/powerpc/platforms/ps3/interrupt.c
+++ b/arch/powerpc/platforms/ps3/interrupt.c
@@ -60,6 +60,8 @@ 
  * gives a usable range of plug values of  {NUM_ISA_INTERRUPTS..63}.  Note
  * that there is no constraint on how many in this set an individual thread
  * can acquire.
+ *
+ * The mask is declared as unsigned long so we can use set/clear_bit on it.
  */
 
 #define PS3_BMP_MINALIGN 64
@@ -68,7 +70,7 @@  struct ps3_bmp {
 	struct {
 		u64 status;
 		u64 unused_1[3];
-		u64 mask;
+		unsigned long mask;
 		u64 unused_2[3];
 	};
 	u64 ipi_debug_brk_mask;