Patchwork [U-Boot,7/9] Tegra30: Add config files (common and Cardhu)

login
register
mail settings
Submitter Tom Warren
Date Sept. 12, 2012, 10:10 p.m.
Message ID <1347487855-27077-8-git-send-email-twarren@nvidia.com>
Download mbox | patch
Permalink /patch/183465/
State Changes Requested
Delegated to: Tom Rini
Headers show

Comments

Tom Warren - Sept. 12, 2012, 10:10 p.m.
Signed-off-by: Tom Warren <twarren@nvidia.com>
---
 include/configs/cardhu.h         |   52 +++++++++++
 include/configs/tegra30-common.h |  188 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 240 insertions(+), 0 deletions(-)
 create mode 100644 include/configs/cardhu.h
 create mode 100644 include/configs/tegra30-common.h
Stephen Warren - Sept. 13, 2012, 10:33 p.m.
On 09/12/2012 04:10 PM, Tom Warren wrote:

> diff --git a/include/configs/tegra30-common.h b/include/configs/tegra30-common.h

> +/*
> + * QUOTE(m) will evaluate to a string version of the value of the macro m
> + * passed in.  The extra level of indirection here is to first evaluate the
> + * macro m before applying the quoting operator.
> + */
> +#define QUOTE_(m)       #m
> +#define QUOTE(m)        QUOTE_(m)

Seems like a good candidate for a common header (not Tegra-common, but
across all of U-Boot).

> +#define CONFIG_SYS_BAUDRATE_TABLE	{4800, 9600, 19200, 38400, 57600,\
> +					115200}

IIRC, that's the default now and can be removed. There may be other
variables the comment applies to - Tom Rini would know better since he
pointed them out in my RPi patches.

> +#define CONFIG_SYS_LOAD_ADDR		(0x80A00800)	/* default */

Hmmm. I notice that both here and the equivalent Tegra20 file, we define
both CONFIG_LOADADDR and CONFIG_SYS_LOAD_ADDR. Should we actually be
defining both, and with different values (is one unused?).
Tom Rini - Sept. 13, 2012, 10:45 p.m.
On 09/13/2012 03:33 PM, Stephen Warren wrote:
> On 09/12/2012 04:10 PM, Tom Warren wrote:
> 
>> diff --git a/include/configs/tegra30-common.h b/include/configs/tegra30-common.h
> 
>> +/*
>> + * QUOTE(m) will evaluate to a string version of the value of the macro m
>> + * passed in.  The extra level of indirection here is to first evaluate the
>> + * macro m before applying the quoting operator.
>> + */
>> +#define QUOTE_(m)       #m
>> +#define QUOTE(m)        QUOTE_(m)
> 
> Seems like a good candidate for a common header (not Tegra-common, but
> across all of U-Boot).

This is __stringify() that Marek needs to address Wolfgang's comment on
still, iirc.

>> +#define CONFIG_SYS_BAUDRATE_TABLE	{4800, 9600, 19200, 38400, 57600,\
>> +					115200}
> 
> IIRC, that's the default now and can be removed. There may be other
> variables the comment applies to - Tom Rini would know better since he
> pointed them out in my RPi patches.

That and the hush prompt one if it's there need to go.
Marek Vasut - Sept. 13, 2012, 11:38 p.m.
Dear Tom Rini,

> On 09/13/2012 03:33 PM, Stephen Warren wrote:
> > On 09/12/2012 04:10 PM, Tom Warren wrote:
> >> diff --git a/include/configs/tegra30-common.h
> >> b/include/configs/tegra30-common.h
> >> 
> >> +/*
> >> + * QUOTE(m) will evaluate to a string version of the value of the macro
> >> m + * passed in.  The extra level of indirection here is to first
> >> evaluate the + * macro m before applying the quoting operator.
> >> + */
> >> +#define QUOTE_(m)       #m
> >> +#define QUOTE(m)        QUOTE_(m)
> > 
> > Seems like a good candidate for a common header (not Tegra-common, but
> > across all of U-Boot).
> 
> This is __stringify() that Marek needs to address Wolfgang's comment on
> still, iirc.

I need to roll out the stringify patches ... the issues should be fixed.

> >> +#define CONFIG_SYS_BAUDRATE_TABLE	{4800, 9600, 19200, 38400, 57600,\
> >> +					115200}
> > 
> > IIRC, that's the default now and can be removed. There may be other
> > variables the comment applies to - Tom Rini would know better since he
> > pointed them out in my RPi patches.
> 
> That and the hush prompt one if it's there need to go.

Best regards,
Marek Vasut
Simon Glass - Sept. 18, 2012, 7:46 p.m.
Hi Tom,

On Wed, Sep 12, 2012 at 3:10 PM, Tom Warren <twarren.nvidia@gmail.com> wrote:
> Signed-off-by: Tom Warren <twarren@nvidia.com>
> ---
>  include/configs/cardhu.h         |   52 +++++++++++
>  include/configs/tegra30-common.h |  188 ++++++++++++++++++++++++++++++++++++++
>  2 files changed, 240 insertions(+), 0 deletions(-)
>  create mode 100644 include/configs/cardhu.h
>  create mode 100644 include/configs/tegra30-common.h
>
> diff --git a/include/configs/cardhu.h b/include/configs/cardhu.h
> new file mode 100644
> index 0000000..bfadbff
> --- /dev/null
> +++ b/include/configs/cardhu.h
> @@ -0,0 +1,52 @@
> +/*
> + *  (C) Copyright 2010-2012
> + *  NVIDIA Corporation <www.nvidia.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#ifndef __CONFIG_H
> +#define __CONFIG_H
> +
> +#include <asm/sizes.h>
> +
> +#include "tegra30-common.h"
> +
> +/* Enable fdt support for Cardhu. Flash the image in u-boot-dtb.bin */
> +#define CONFIG_DEFAULT_DEVICE_TREE     tegra30-cardhu
> +#define CONFIG_OF_CONTROL
> +#define CONFIG_OF_SEPARATE
> +
> +/* High-level configuration options */
> +#define V_PROMPT               "Tegra30 (Cardhu) # "
> +#define CONFIG_TEGRA_BOARD_STRING      "NVIDIA Cardhu"
> +
> +/* Board-specific serial config */
> +#define CONFIG_SERIAL_MULTI
> +#define CONFIG_TEGRA_ENABLE_UARTA
> +#define CONFIG_SYS_NS16550_COM1                NV_PA_APB_UARTA_BASE
> +
> +#define CONFIG_MACH_TYPE               MACH_TYPE_CARDHU
> +
> +#define CONFIG_BOARD_EARLY_INIT_F
> +#define CONFIG_ENV_IS_NOWHERE
> +
> +#include "tegra-common-post.h"
> +
> +#endif /* __CONFIG_H */
> diff --git a/include/configs/tegra30-common.h b/include/configs/tegra30-common.h
> new file mode 100644
> index 0000000..b23823d
> --- /dev/null
> +++ b/include/configs/tegra30-common.h
> @@ -0,0 +1,188 @@
> +/*
> + *  (C) Copyright 2010-2012
> + *  NVIDIA Corporation <www.nvidia.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#ifndef __TEGRA30_COMMON_H
> +#define __TEGRA30_COMMON_H
> +#include <asm/sizes.h>
> +
> +/*
> + * QUOTE(m) will evaluate to a string version of the value of the macro m
> + * passed in.  The extra level of indirection here is to first evaluate the
> + * macro m before applying the quoting operator.
> + */
> +#define QUOTE_(m)       #m
> +#define QUOTE(m)        QUOTE_(m)
> +
> +/*
> + * High Level Configuration Options
> + */
> +#define CONFIG_ARMCORTEXA9             /* This is an ARM V7 CPU core */
> +#define CONFIG_TEGRA30                 /* in a NVidia Tegra30 core */
> +#define CONFIG_TEGRA                   /* which is a Tegra generic machine */
> +#define CONFIG_SYS_L2CACHE_OFF         /* No L2 cache */
> +
> +#define CONFIG_SYS_CACHELINE_SIZE      32
> +
> +#include <asm/arch/tegra30.h>          /* get chip and board defs */
> +
> +/*
> + * Display CPU and Board information
> + */
> +#define CONFIG_DISPLAY_CPUINFO
> +#define CONFIG_DISPLAY_BOARDINFO
> +
> +#define CONFIG_CMDLINE_TAG             /* enable passing of ATAGs */
> +#define CONFIG_OF_LIBFDT               /* enable passing of devicetree */

Do you think there should be a tegra-common.h, included by
tegra20-common and tegra30-common? That was the approach we talk in
the Chromium tree.

Regards,
Simon
Tom Warren - Sept. 18, 2012, 9:21 p.m.
Simon,

On Tue, Sep 18, 2012 at 12:46 PM, Simon Glass <sjg@chromium.org> wrote:
> Hi Tom,
>
> On Wed, Sep 12, 2012 at 3:10 PM, Tom Warren <twarren.nvidia@gmail.com> wrote:
>> Signed-off-by: Tom Warren <twarren@nvidia.com>
>> ---
>>  include/configs/cardhu.h         |   52 +++++++++++
>>  include/configs/tegra30-common.h |  188 ++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 240 insertions(+), 0 deletions(-)
>>  create mode 100644 include/configs/cardhu.h
>>  create mode 100644 include/configs/tegra30-common.h
>>
>> diff --git a/include/configs/cardhu.h b/include/configs/cardhu.h
>> new file mode 100644
>> index 0000000..bfadbff
>> --- /dev/null
>> +++ b/include/configs/cardhu.h
>> @@ -0,0 +1,52 @@
>> +/*
>> + *  (C) Copyright 2010-2012
>> + *  NVIDIA Corporation <www.nvidia.com>
>> + *
>> + * See file CREDITS for list of people who contributed to this
>> + * project.
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 of
>> + * the License, or (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program; if not, write to the Free Software
>> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>> + * MA 02111-1307 USA
>> + */
>> +
>> +#ifndef __CONFIG_H
>> +#define __CONFIG_H
>> +
>> +#include <asm/sizes.h>
>> +
>> +#include "tegra30-common.h"
>> +
>> +/* Enable fdt support for Cardhu. Flash the image in u-boot-dtb.bin */
>> +#define CONFIG_DEFAULT_DEVICE_TREE     tegra30-cardhu
>> +#define CONFIG_OF_CONTROL
>> +#define CONFIG_OF_SEPARATE
>> +
>> +/* High-level configuration options */
>> +#define V_PROMPT               "Tegra30 (Cardhu) # "
>> +#define CONFIG_TEGRA_BOARD_STRING      "NVIDIA Cardhu"
>> +
>> +/* Board-specific serial config */
>> +#define CONFIG_SERIAL_MULTI
>> +#define CONFIG_TEGRA_ENABLE_UARTA
>> +#define CONFIG_SYS_NS16550_COM1                NV_PA_APB_UARTA_BASE
>> +
>> +#define CONFIG_MACH_TYPE               MACH_TYPE_CARDHU
>> +
>> +#define CONFIG_BOARD_EARLY_INIT_F
>> +#define CONFIG_ENV_IS_NOWHERE
>> +
>> +#include "tegra-common-post.h"
>> +
>> +#endif /* __CONFIG_H */
>> diff --git a/include/configs/tegra30-common.h b/include/configs/tegra30-common.h
>> new file mode 100644
>> index 0000000..b23823d
>> --- /dev/null
>> +++ b/include/configs/tegra30-common.h
>> @@ -0,0 +1,188 @@
>> +/*
>> + *  (C) Copyright 2010-2012
>> + *  NVIDIA Corporation <www.nvidia.com>
>> + *
>> + * See file CREDITS for list of people who contributed to this
>> + * project.
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 of
>> + * the License, or (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program; if not, write to the Free Software
>> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>> + * MA 02111-1307 USA
>> + */
>> +
>> +#ifndef __TEGRA30_COMMON_H
>> +#define __TEGRA30_COMMON_H
>> +#include <asm/sizes.h>
>> +
>> +/*
>> + * QUOTE(m) will evaluate to a string version of the value of the macro m
>> + * passed in.  The extra level of indirection here is to first evaluate the
>> + * macro m before applying the quoting operator.
>> + */
>> +#define QUOTE_(m)       #m
>> +#define QUOTE(m)        QUOTE_(m)
>> +
>> +/*
>> + * High Level Configuration Options
>> + */
>> +#define CONFIG_ARMCORTEXA9             /* This is an ARM V7 CPU core */
>> +#define CONFIG_TEGRA30                 /* in a NVidia Tegra30 core */
>> +#define CONFIG_TEGRA                   /* which is a Tegra generic machine */
>> +#define CONFIG_SYS_L2CACHE_OFF         /* No L2 cache */
>> +
>> +#define CONFIG_SYS_CACHELINE_SIZE      32
>> +
>> +#include <asm/arch/tegra30.h>          /* get chip and board defs */
>> +
>> +/*
>> + * Display CPU and Board information
>> + */
>> +#define CONFIG_DISPLAY_CPUINFO
>> +#define CONFIG_DISPLAY_BOARDINFO
>> +
>> +#define CONFIG_CMDLINE_TAG             /* enable passing of ATAGs */
>> +#define CONFIG_OF_LIBFDT               /* enable passing of devicetree */
>
> Do you think there should be a tegra-common.h, included by
> tegra20-common and tegra30-common? That was the approach we talk in
> the Chromium tree.

There can be. There's already a tegra-common-post.h header for boot
stuff. I'll take a look.

Thanks
>
> Regards,
> Simon

Patch

diff --git a/include/configs/cardhu.h b/include/configs/cardhu.h
new file mode 100644
index 0000000..bfadbff
--- /dev/null
+++ b/include/configs/cardhu.h
@@ -0,0 +1,52 @@ 
+/*
+ *  (C) Copyright 2010-2012
+ *  NVIDIA Corporation <www.nvidia.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+#include <asm/sizes.h>
+
+#include "tegra30-common.h"
+
+/* Enable fdt support for Cardhu. Flash the image in u-boot-dtb.bin */
+#define CONFIG_DEFAULT_DEVICE_TREE	tegra30-cardhu
+#define CONFIG_OF_CONTROL
+#define CONFIG_OF_SEPARATE
+
+/* High-level configuration options */
+#define V_PROMPT		"Tegra30 (Cardhu) # "
+#define CONFIG_TEGRA_BOARD_STRING	"NVIDIA Cardhu"
+
+/* Board-specific serial config */
+#define CONFIG_SERIAL_MULTI
+#define CONFIG_TEGRA_ENABLE_UARTA
+#define CONFIG_SYS_NS16550_COM1		NV_PA_APB_UARTA_BASE
+
+#define CONFIG_MACH_TYPE		MACH_TYPE_CARDHU
+
+#define CONFIG_BOARD_EARLY_INIT_F
+#define CONFIG_ENV_IS_NOWHERE
+
+#include "tegra-common-post.h"
+
+#endif /* __CONFIG_H */
diff --git a/include/configs/tegra30-common.h b/include/configs/tegra30-common.h
new file mode 100644
index 0000000..b23823d
--- /dev/null
+++ b/include/configs/tegra30-common.h
@@ -0,0 +1,188 @@ 
+/*
+ *  (C) Copyright 2010-2012
+ *  NVIDIA Corporation <www.nvidia.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __TEGRA30_COMMON_H
+#define __TEGRA30_COMMON_H
+#include <asm/sizes.h>
+
+/*
+ * QUOTE(m) will evaluate to a string version of the value of the macro m
+ * passed in.  The extra level of indirection here is to first evaluate the
+ * macro m before applying the quoting operator.
+ */
+#define QUOTE_(m)       #m
+#define QUOTE(m)        QUOTE_(m)
+
+/*
+ * High Level Configuration Options
+ */
+#define CONFIG_ARMCORTEXA9		/* This is an ARM V7 CPU core */
+#define CONFIG_TEGRA30			/* in a NVidia Tegra30 core */
+#define CONFIG_TEGRA			/* which is a Tegra generic machine */
+#define CONFIG_SYS_L2CACHE_OFF		/* No L2 cache */
+
+#define CONFIG_SYS_CACHELINE_SIZE	32
+
+#include <asm/arch/tegra30.h>		/* get chip and board defs */
+
+/*
+ * Display CPU and Board information
+ */
+#define CONFIG_DISPLAY_CPUINFO
+#define CONFIG_DISPLAY_BOARDINFO
+
+#define CONFIG_CMDLINE_TAG		/* enable passing of ATAGs */
+#define CONFIG_OF_LIBFDT		/* enable passing of devicetree */
+
+/* Environment */
+#define CONFIG_ENV_VARS_UBOOT_CONFIG
+#define CONFIG_ENV_SIZE			0x2000	/* Total Size Environment */
+
+/*
+ * Size of malloc() pool
+ */
+#define CONFIG_SYS_MALLOC_LEN		(4 << 20)	/* 4MB  */
+
+/*
+ * PllX Configuration
+ */
+#define CONFIG_SYS_CPU_OSC_FREQUENCY	1000000	/* Set CPU clock to 1GHz */
+
+/*
+ * NS16550 Configuration
+ */
+#define V_NS16550_CLK			216000000	/* 216MHz (pllp_out0) */
+
+#define CONFIG_SYS_NS16550
+#define CONFIG_SYS_NS16550_SERIAL
+#define CONFIG_SYS_NS16550_REG_SIZE	(-4)
+#define CONFIG_SYS_NS16550_CLK		V_NS16550_CLK
+
+/*
+ * select serial console configuration
+ */
+#define CONFIG_CONS_INDEX	1
+
+/* allow to overwrite serial and ethaddr */
+#define CONFIG_ENV_OVERWRITE
+#define CONFIG_BAUDRATE			115200
+#define CONFIG_SYS_BAUDRATE_TABLE	{4800, 9600, 19200, 38400, 57600,\
+					115200}
+
+/* include default commands */
+#include <config_cmd_default.h>
+
+/* remove unused commands */
+#undef CONFIG_CMD_FLASH		/* flinfo, erase, protect */
+#undef CONFIG_CMD_FPGA		/* FPGA configuration support */
+#undef CONFIG_CMD_IMI
+#undef CONFIG_CMD_IMLS
+#undef CONFIG_CMD_NFS		/* NFS support */
+#undef CONFIG_CMD_NET		/* network support */
+
+/* turn on command-line edit/hist/auto */
+#define CONFIG_CMDLINE_EDITING
+#define CONFIG_COMMAND_HISTORY
+#define CONFIG_AUTO_COMPLETE
+
+#define CONFIG_SYS_NO_FLASH
+
+/* Environment information, boards can override if required */
+#define CONFIG_CONSOLE_MUX
+#define CONFIG_SYS_CONSOLE_IS_IN_ENV
+#define TEGRA_DEVICE_SETTINGS	"stdin=serial\0" \
+				"stdout=serial\0" \
+				"stderr=serial\0"
+
+#define CONFIG_LOADADDR		0x80408000	/* def. location for kernel */
+#define CONFIG_BOOTDELAY	2		/* -1 to disable auto boot */
+
+/*
+ * Miscellaneous configurable options
+ */
+#define CONFIG_SYS_LONGHELP		/* undef to save memory */
+#define CONFIG_SYS_HUSH_PARSER		/* use "hush" command parser */
+#define CONFIG_SYS_PROMPT		V_PROMPT
+/*
+ * Increasing the size of the IO buffer as default nfsargs size is more
+ *  than 256 and so it is not possible to edit it
+ */
+#define CONFIG_SYS_CBSIZE		(256 * 2) /* Console I/O Buffer Size */
+/* Print Buffer Size */
+#define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
+					sizeof(CONFIG_SYS_PROMPT) + 16)
+#define CONFIG_SYS_MAXARGS		16	/* max number of command args */
+/* Boot Argument Buffer Size */
+#define CONFIG_SYS_BARGSIZE		(CONFIG_SYS_CBSIZE)
+
+#define CONFIG_SYS_MEMTEST_START	(NV_PA_SDRC_CS0 + 0x600000)
+#define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_MEMTEST_START + 0x100000)
+
+#define CONFIG_SYS_LOAD_ADDR		(0x80A00800)	/* default */
+#define CONFIG_SYS_HZ			1000
+
+/*-----------------------------------------------------------------------
+ * Stack sizes
+ *
+ * The stack sizes are set up in start.S using the settings below
+ */
+#define CONFIG_STACKBASE	(NV_PA_SDRAM_BASE + 0x2800000)	/* 40MB */
+#define CONFIG_STACKSIZE	0x20000		/* 128K regular stack*/
+
+/*-----------------------------------------------------------------------
+ * Physical Memory Map
+ */
+#define CONFIG_NR_DRAM_BANKS	1
+#define PHYS_SDRAM_1		NV_PA_SDRC_CS0
+#define PHYS_SDRAM_1_SIZE	0x20000000	/* 512M */
+
+#define CONFIG_SYS_TEXT_BASE	0x8010e000
+#define CONFIG_SYS_SDRAM_BASE	PHYS_SDRAM_1
+
+#define CONFIG_SYS_INIT_RAM_ADDR	CONFIG_STACKBASE
+#define CONFIG_SYS_INIT_RAM_SIZE	CONFIG_SYS_MALLOC_LEN
+#define CONFIG_SYS_INIT_SP_ADDR		(CONFIG_SYS_INIT_RAM_ADDR + \
+						CONFIG_SYS_INIT_RAM_SIZE - \
+						GENERATED_GBL_DATA_SIZE)
+
+#define CONFIG_TEGRA_GPIO
+#define CONFIG_CMD_GPIO
+#define CONFIG_CMD_ENTERRCM
+#define CONFIG_CMD_BOOTZ
+
+/* Defines for SPL */
+#define CONFIG_SPL
+#define CONFIG_SPL_NAND_SIMPLE
+#define CONFIG_SPL_TEXT_BASE		0x80108000
+#define CONFIG_SPL_MAX_SIZE		0x00006000
+#define CONFIG_SYS_SPL_MALLOC_START	0x80090000
+#define CONFIG_SYS_SPL_MALLOC_SIZE	0x00010000
+#define CONFIG_SPL_STACK		0x800ffffc
+
+#define CONFIG_SPL_LIBCOMMON_SUPPORT
+#define CONFIG_SPL_LIBGENERIC_SUPPORT
+#define CONFIG_SPL_SERIAL_SUPPORT
+#define CONFIG_SPL_GPIO_SUPPORT
+#define CONFIG_SPL_LDSCRIPT		"$(CPUDIR)/tegra30/u-boot-spl.lds"
+
+#endif /* __TEGRA30_COMMON_H */