Patchwork [MTD-UTILS] io_update test: correct lseek parameters order

login
register
mail settings
Submitter Richard Genoud
Date Sept. 12, 2012, 2:37 p.m.
Message ID <1347460674-3536-1-git-send-email-richard.genoud@gmail.com>
Download mbox | patch
Permalink /patch/183389/
State Accepted
Commit c009e12a7c87ed8dc591d7c67fd71b53b6ebf538
Headers show

Comments

Richard Genoud - Sept. 12, 2012, 2:37 p.m.
There's a typo in lseek parameters order.

But, due to the value of SEEK_SET, this commit doesn't introduce a
change.

Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
---
 tests/ubi-tests/io_update.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Artem Bityutskiy - Sept. 25, 2012, 2:05 p.m.
On Wed, 2012-09-12 at 16:37 +0200, Richard Genoud wrote:
> There's a typo in lseek parameters order.
> 
> But, due to the value of SEEK_SET, this commit doesn't introduce a
> change.
> 
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>

Pushed to mtd-utils.git, thanks!

Patch

diff --git a/tests/ubi-tests/io_update.c b/tests/ubi-tests/io_update.c
index 0259446..e8f0986 100644
--- a/tests/ubi-tests/io_update.c
+++ b/tests/ubi-tests/io_update.c
@@ -158,7 +158,7 @@  static int test_update1(struct ubi_vol_info *vol_info, int leb_change)
 		}
 
 		/* Check data */
-		if ((ret = lseek(fd, SEEK_SET, 0)) != 0) {
+		if ((ret = lseek(fd, 0, SEEK_SET)) != 0) {
 			failed("lseek");
 			errmsg("cannot seek to 0");
 			goto close;