Patchwork Replace genphy_update_link() call with phy_read_status()

mail settings
Submitter Alexander Sverdlin
Date Sept. 12, 2012, 11:23 a.m.
Message ID <>
Download mbox | patch
Permalink /patch/183327/
State Changes Requested
Delegated to: David Miller
Headers show


Alexander Sverdlin - Sept. 12, 2012, 11:23 a.m.
From: Alexander Sverdlin <>

Replace genphy_update_link() call with phy_read_status() 

Code in phy.c should not call genphy_*() functions directly, this breaks PHY layer abstraction.
Some drivers may re-implement "read_status" callback and it's not being called in one place of
PHY state machine, where genphy_update_link() is called instead. So fix it.
For drivers that rely on genphy_* implementation nothing changed, as genphy_read_status() calls
genphy_update_link() anyway.

Signed-off-by: Alexander Sverdlin <>
 drivers/net/phy/phy.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at


diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index dfca51d..cfed41c 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -839,7 +839,7 @@  void phy_state_machine(struct work_struct *work)
 		case PHY_FORCING:
-			err = genphy_update_link(phydev);
+			err = phy_read_status(phydev);
 			if (err)