Patchwork [v2,1/5] softfloat: make float_muladd_negate_* flags independent

login
register
mail settings
Submitter Aurelien Jarno
Date Sept. 11, 2012, 6:47 p.m.
Message ID <1347389233-9068-2-git-send-email-aurelien@aurel32.net>
Download mbox | patch
Permalink /patch/183168/
State New
Headers show

Comments

Aurelien Jarno - Sept. 11, 2012, 6:47 p.m.
From: Max Filippov <jcmvbkbc@gmail.com>

Flags passed into float{32,64}_muladd are treated as bits; assign
independent bits to float_muladd_negate_* to allow precise control over
what gets negated in float{32,64}_muladd.

Cc: Alexander Graf <agraf@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
 fpu/softfloat.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Alexander Graf - Sept. 13, 2012, 11:23 p.m.
On 11.09.2012, at 20:47, Aurelien Jarno wrote:

> From: Max Filippov <jcmvbkbc@gmail.com>
> 
> Flags passed into float{32,64}_muladd are treated as bits; assign
> independent bits to float_muladd_negate_* to allow precise control over
> what gets negated in float{32,64}_muladd.
> 
> Cc: Alexander Graf <agraf@suse.de>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>

Thanks, applied all to ppc-next. Please provide a cover letter next time - that makes it easier for me to grasp what the purpose of a patch set is :). It's also a more natural fit for the applied message.


Alex
Aurelien Jarno - Sept. 14, 2012, 5:57 a.m.
On Fri, Sep 14, 2012 at 01:23:16AM +0200, Alexander Graf wrote:
> 
> On 11.09.2012, at 20:47, Aurelien Jarno wrote:
> 
> > From: Max Filippov <jcmvbkbc@gmail.com>
> > 
> > Flags passed into float{32,64}_muladd are treated as bits; assign
> > independent bits to float_muladd_negate_* to allow precise control over
> > what gets negated in float{32,64}_muladd.
> > 
> > Cc: Alexander Graf <agraf@suse.de>
> > Cc: Peter Maydell <peter.maydell@linaro.org>
> > Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
> > Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> 
> Thanks, applied all to ppc-next. Please provide a cover letter next time - that makes it easier for me to grasp what the purpose of a patch set is :). It's also a more natural fit for the applied message.
> 

Thanks. There was a cover letter in this new version, but I did a
mistake and it only went to the list, not to you. Will pay attention
next time.

Patch

diff --git a/fpu/softfloat.h b/fpu/softfloat.h
index feec3a1..2860ca0 100644
--- a/fpu/softfloat.h
+++ b/fpu/softfloat.h
@@ -219,7 +219,7 @@  void float_raise( int8 flags STATUS_PARAM);
 enum {
     float_muladd_negate_c = 1,
     float_muladd_negate_product = 2,
-    float_muladd_negate_result = 3,
+    float_muladd_negate_result = 4,
 };
 
 /*----------------------------------------------------------------------------