Patchwork [ARM] Allow auto-vectorizer to use vfma.

login
register
mail settings
Submitter Tobias Burnus
Date Sept. 11, 2012, 1:17 p.m.
Message ID <504F39FC.90003@net-b.de>
Download mbox | patch
Permalink /patch/183111/
State New
Headers show

Comments

Tobias Burnus - Sept. 11, 2012, 1:17 p.m.
On 09/11/2012 03:08 PM, Tobias Burnus wrote:
> your patch broke bootstrapping here:
> /home/tob/projects/gcc-git/gcc/gcc/doc//sourcebuild.texi:1537: Node 
> `arm_neon_ok' previously defined at line 1532.

I fixed it (Rev. 191181) with the attached patch. arm_neon_ok should 
have been arm_neon2_ok. (I also changed spaces into tabs in the ChangeLog.)

Tobias

PS: Fortunately, documentation changes do not require an all-language 
bootstrap.


> On 09/11/2012 02:54 PM, Ramana Radhakrishnan wrote:
>> Hi,
>>
>> This allows the auto-vectorizer to use vfma under Ofast or ffast-math.
>> I have a follow-up patch which will add support for these from
>> arm_neon.h as well before someone asks. It's being regression tested as
>> we speak and that'll follow shortly.
>>
>> Tested on A15 silicon native with no regressions.
>>
>> Committed.
>>
>>
>> regards,
>> Ramana
>>
>>
>>
>> 2012-09-11  Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
>>          Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
>>
>>      * config/arm/neon.md (fma<VCVTF:mode>4): New pattern.
>>      (*fmsub<VCVTF:mode>4): Likewise.
>>      * doc/sourcebuild.texi (arm_neon_v2_ok, arm_neon_v2_hw): 
>> Document it.
>>
>> 2012-09-11  Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
>>          Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
>>
>>      * gcc.target/arm/neon-vfma-1.c: New testcase.
>>      * gcc.target/arm/neon-vfms-1.c: Likewise.
>>      * gcc.target/arm/neon-vmla-1.c: Update test to use int instead
>>      of float.
>>      * gcc.target/arm/neon-vmls-1.c: Likewise.
>>      * lib/target-supports.exp (add_options_for_arm_neonv2): New
>>      function.
>>      (check_effective_target_arm_neonv2_ok_nocache): Likewise.
>>      (check_effective_target_arm_neonv2_ok): Likewise.
>>      (check_effective_target_arm_neonv2_hw): Likewise.
>>      (check_effective_target_arm_neonv2): Likewise.
>
>

Patch

Index: gcc/ChangeLog
===================================================================
--- gcc/ChangeLog	(revision 191180)
+++ gcc/ChangeLog	(working copy)
@@ -1,9 +1,13 @@ 
+2012-09-11  Tobias Burnus  <burnus@net-b.de>
+
+	* doc/sourcebuild.texi (arm_neon_v2_ok): Fix @anchor.
+
 2012-09-11  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
-            Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
+	    Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
 
-       * config/arm/neon.md (fma<VCVTF:mode>4): New pattern.
-       (*fmsub<VCVTF:mode>4): Likewise.
-       * doc/sourcebuild.texi (arm_neon_v2_ok, arm_neon_v2_hw):  Document it.
+	* config/arm/neon.md (fma<VCVTF:mode>4): New pattern.
+	(*fmsub<VCVTF:mode>4): Likewise.
+	* doc/sourcebuild.texi (arm_neon_v2_ok, arm_neon_v2_hw):  Document it.
 
 2012-09-11  Aldy Hernandez  <aldyh@redhat.com>
 
Index: gcc/doc/sourcebuild.texi
===================================================================
--- gcc/doc/sourcebuild.texi	(revision 191180)
+++ gcc/doc/sourcebuild.texi	(working copy)
@@ -1534,7 +1534,7 @@  ARM Target supports @code{-mfpu=neon -mfloat-abi=s
 options.  Some multilibs may be incompatible with these options.
 
 @item arm_neonv2_ok
-@anchor{arm_neon_ok}
+@anchor{arm_neon2_ok}
 ARM Target supports @code{-mfpu=neon -mfloat-abi=softfp} or compatible
 options.  Some multilibs may be incompatible with these options.