From patchwork Tue Sep 11 10:39:49 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 183077 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 5535C2C0084 for ; Tue, 11 Sep 2012 20:42:54 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1347964975; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Date: From:To:Subject:Message-ID:User-Agent:MIME-Version:Content-Type: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=Xrh+Xjtath1JfkSIYY0T zJWfDKw=; b=vuJ+pAmYG1zOivl8riFIc3/SuyIJt7FvvhabwePdDneRmAaSMI16 op+4FhVewQSiqE+Efep5C7hXbrxug1/wdjle1wr5pNiGZyhIoiP5GfUpfL5Fp2EQ fskODlv9Qf5Y0aZvPwATnfNMswuFnCeaUHF+2Y318rIWh5YLR9Lpbg0= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Date:From:To:Subject:Message-ID:User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=jMCpP1J7TKeW+1q1EsYvw+MuIyoc1D3CVoWgEeKT4HUvBJwv7skPYIHaJ5nAUG blIvX4Oyqxut7Ys9C8nut+e16jzrw7sfbLF2mOkUttuluiqkt/CxaiI4P18oi6y2 4V6apcCpybb+H4VO7sdkZGKJWzYaLOhfmuzRLFrSPyubg=; Received: (qmail 9433 invoked by alias); 11 Sep 2012 10:42:51 -0000 Received: (qmail 9419 invoked by uid 22791); 11 Sep 2012 10:42:51 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Sep 2012 10:42:38 +0000 Received: from relay1.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 9F7B9A398F for ; Tue, 11 Sep 2012 12:42:37 +0200 (CEST) Date: Tue, 11 Sep 2012 12:39:49 +0200 (CEST) From: Richard Guenther To: gcc-patches@gcc.gnu.org Subject: [PATCH] Fix PR54534 Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org The backport of the patch for PR53572 caused us to remove unused decls at -O0, a regresion on the branch - fixed by the following. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2012-09-11 Richard Guenther PR debug/54534 * cgraph.h (varpool_can_remove_if_no_refs): Restore dependence on flag_toplevel_reorder. Index: gcc/cgraph.h =================================================================== --- gcc/cgraph.h (revision 191174) +++ gcc/cgraph.h (working copy) @@ -951,7 +951,7 @@ varpool_can_remove_if_no_refs (struct va return (!node->force_output && !node->used_from_other_partition && ((DECL_COMDAT (node->decl) && !varpool_used_from_object_file_p (node)) - || !node->externally_visible + || (flag_toplevel_reorder && !node->externally_visible) || DECL_HAS_VALUE_EXPR_P (node->decl))); }