Patchwork Bootstrap fails (was: Remove unnecessary VEC function overloads.)

login
register
mail settings
Submitter Dominique Dhumieres
Date Sept. 11, 2012, 10:12 a.m.
Message ID <20120911101221.E64C83BE1C@mailhost.lps.ens.fr>
Download mbox | patch
Permalink /patch/183075/
State New
Headers show

Comments

Dominique Dhumieres - Sept. 11, 2012, 10:12 a.m.
> Fixed with the attached.

Followed by the same failure on darwin. Fixed with

(now at stage 2).

TIA

Dominique
Diego Novillo - Sept. 11, 2012, 11:51 a.m.
On 2012-09-11 06:12 , Dominique Dhumieres wrote:
>> Fixed with the attached.
>
> Followed by the same failure on darwin. Fixed with
>
> --- ../_clean/gcc/config/darwin.c	2012-07-09 22:06:21.000000000 +0200
> +++ ../p_work/gcc/config/darwin.c	2012-09-11 11:53:02.000000000 +0200
> @@ -1878,7 +1878,7 @@ darwin_asm_named_section (const char *na
>            the assumption of how this is done.  */
>         if (lto_section_names == NULL)
>           lto_section_names = VEC_alloc (darwin_lto_section_e, gc, 16);
> -      VEC_safe_push (darwin_lto_section_e, gc, lto_section_names, &e);
> +      VEC_safe_push (darwin_lto_section_e, gc, lto_section_names, e);
>      }
>     else if (strncmp (name, "__DWARF,", 8) == 0)
>       darwin_asm_dwarf_section (name, flags, decl);
> @@ -2698,7 +2698,7 @@ darwin_asm_dwarf_section (const char *na
>         fprintf (asm_out_file, "Lsection%.*s:\n", namelen, sname);
>         e.count = 1;
>         e.name = xstrdup (sname);
> -      VEC_safe_push (dwarf_sect_used_entry, gc, dwarf_sect_names_table, &e);
> +      VEC_safe_push (dwarf_sect_used_entry, gc, dwarf_sect_names_table, e);
>       }
>   }

Gah, my grep did not include config/*.c.

This is ok, of course.


Diego.
Dominique Dhumieres - Sept. 11, 2012, 12:42 p.m.
> This is ok, of course.

Then could you please commit it (I don't have write access)?

TIA

Dominique

Patch

--- ../_clean/gcc/config/darwin.c	2012-07-09 22:06:21.000000000 +0200
+++ ../p_work/gcc/config/darwin.c	2012-09-11 11:53:02.000000000 +0200
@@ -1878,7 +1878,7 @@  darwin_asm_named_section (const char *na
          the assumption of how this is done.  */
       if (lto_section_names == NULL)
         lto_section_names = VEC_alloc (darwin_lto_section_e, gc, 16);
-      VEC_safe_push (darwin_lto_section_e, gc, lto_section_names, &e);
+      VEC_safe_push (darwin_lto_section_e, gc, lto_section_names, e);
    }
   else if (strncmp (name, "__DWARF,", 8) == 0)
     darwin_asm_dwarf_section (name, flags, decl);
@@ -2698,7 +2698,7 @@  darwin_asm_dwarf_section (const char *na
       fprintf (asm_out_file, "Lsection%.*s:\n", namelen, sname);
       e.count = 1;
       e.name = xstrdup (sname);
-      VEC_safe_push (dwarf_sect_used_entry, gc, dwarf_sect_names_table, &e);
+      VEC_safe_push (dwarf_sect_used_entry, gc, dwarf_sect_names_table, e);
     }
 }