From patchwork Tue Sep 11 07:05:11 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhang, Yang Z" X-Patchwork-Id: 183034 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 83BCD2C008A for ; Tue, 11 Sep 2012 17:05:37 +1000 (EST) Received: from localhost ([::1]:32908 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBKXP-00014L-J8 for incoming@patchwork.ozlabs.org; Tue, 11 Sep 2012 03:05:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBKXD-000148-30 for qemu-devel@nongnu.org; Tue, 11 Sep 2012 03:05:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBKX6-0001OB-8a for qemu-devel@nongnu.org; Tue, 11 Sep 2012 03:05:22 -0400 Received: from mga11.intel.com ([192.55.52.93]:58912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBKX6-0001K7-2M for qemu-devel@nongnu.org; Tue, 11 Sep 2012 03:05:16 -0400 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 11 Sep 2012 00:05:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,402,1344236400"; d="scan'208";a="220420524" Received: from fmsmsx106.amr.corp.intel.com ([10.19.9.37]) by fmsmga002.fm.intel.com with ESMTP; 11 Sep 2012 00:05:13 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.19.9.52) by FMSMSX106.amr.corp.intel.com (10.19.9.37) with Microsoft SMTP Server (TLS) id 14.1.355.2; Tue, 11 Sep 2012 00:05:12 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX101.amr.corp.intel.com (10.19.9.52) with Microsoft SMTP Server (TLS) id 14.1.355.2; Tue, 11 Sep 2012 00:05:12 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.239]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.175]) with mapi id 14.01.0355.002; Tue, 11 Sep 2012 15:05:11 +0800 From: "Zhang, Yang Z" To: Stefan Weil Thread-Topic: [Qemu-devel] buildbot failure in qemu on default_mingw32 Thread-Index: AQHNj9xWtfXbVsHwV0uUdUCWhqBnEZeEs39Q Date: Tue, 11 Sep 2012 07:05:11 +0000 Message-ID: References: <20120910235402.7060E41136@buildbot.b1-systems.de> <504EC8A8.4070501@weilnetz.de> In-Reply-To: <504EC8A8.4070501@weilnetz.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.93 Cc: Paolo Bonzini , "qemu-devel@nongnu.org" Subject: Re: [Qemu-devel] buildbot failure in qemu on default_mingw32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org how about the following patch: Best regards, Yang > -----Original Message----- > From: Stefan Weil [mailto:sw@weilnetz.de] > Sent: Tuesday, September 11, 2012 1:14 PM > To: Zhang, Yang Z > Cc: Paolo Bonzini; qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] buildbot failure in qemu on default_mingw32 > > MinGW has no gmtime_r() which was added here: > > commit 41a9b8b24d59acec462b0d8e0d2a7ffce6031d55 > Author: Yang Zhang > Date: Thu Aug 2 18:04:10 2012 +0200 > > RTC: Add divider reset support > > The first update cycle begins one-half seconds after divider > reset is removed. This feature is useful for testing. > > Signed-off-by: Yang Zhang > Signed-off-by: Paolo Bonzini > Signed-off-by: Anthony Liguori > > - sw > > > Am 11.09.2012 01:54, schrieb qemu@buildbot.b1-systems.de: > > The Buildbot has detected a new failure on builder default_mingw32 while > building qemu. > > Full details are available at: > > http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/372 > > > > Buildbot URL: http://buildbot.b1-systems.de/qemu/ > > > > Buildslave for this Build: kraxel_rhel61 > > > > Build Reason: The Nightly scheduler named 'nightly_default' triggered this build > > Build Source Stamp: [branch master] HEAD > > Blamelist: > > > > BUILD FAILED: failed compile > > > > sincerely, > > -The Buildbot > > diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index d63554f..30bbbe6 100644 --- a/hw/mc146818rtc.c +++ b/hw/mc146818rtc.c @@ -556,14 +556,14 @@ static void rtc_set_cmos(RTCState *s, const struct tm *tm) static void rtc_update_time(RTCState *s) { - struct tm ret; + struct tm *ret; time_t guest_sec; int64_t guest_nsec; guest_nsec = get_guest_rtc_ns(s); guest_sec = guest_nsec / NSEC_PER_SEC; - gmtime_r(&guest_sec, &ret); - rtc_set_cmos(s, &ret); + ret = gmtime(&guest_sec); + rtc_set_cmos(s, ret); } static int update_in_progress(RTCState *s)