[v3,10/10] mtd: nand: omap2: use gpmc provided irqs

Submitted by Mohammed Afzal on Sept. 11, 2012, 5:36 a.m.

Details

Message ID C8443D0743D26F4388EA172BF4E2A7A93E9E1905@DBDE01.ent.ti.com
State New, archived
Headers show

Commit Message

Mohammed Afzal Sept. 11, 2012, 5:36 a.m.
Hi Tony,

On Tue, Sep 11, 2012 at 05:47:10, Tony Lindgren wrote:

> FYI, looks like a new warning got introduced, so I've

> committed the following trivial patch on top of this series.


I was not careful enough, sorry. Thanks for fixing it.

Another hunk as follows would also be required for error
path even though compiler didn't complain.

Not sure whether you can fixup or I should post as a
separate patch.

As an aside, there was compiler warning before this
series, but I didn't dare to touch it, so a warning
was seen but thought it was due to the earlier one.
And now Arnd has fixed the original warning.

Regards
Afzal



> From: Tony Lindgren <tony@atomide.com>

> Date: Mon, 10 Sep 2012 17:14:13 -0700

> Subject: [PATCH] mtd: nand omap2: Fix uninitialized err warning

> 

> Commit bd4156fd (mtd: nand: omap2: use gpmc provided irqs)

> introduced a new warning:

> 

> drivers/mtd/nand/omap2.c: In function ‘omap_nand_probe’:

> drivers/mtd/nand/omap2.c:1267: warning: ‘err’ may be used uninitialized in this function

> 

> Signed-off-by: Tony Lindgren <tony@atomide.com>

> 

> --- a/drivers/mtd/nand/omap2.c

> +++ b/drivers/mtd/nand/omap2.c

> @@ -1389,6 +1389,7 @@ static int __devinit omap_nand_probe(struct platform_device *pdev)

>  		info->gpmc_irq_fifo = platform_get_irq(pdev, 0);

>  		if (info->gpmc_irq_fifo <= 0) {

>  			dev_err(&pdev->dev, "error getting fifo irq\n");

> +			err = -ENODEV;

>  			goto out_release_mem_region;

>  		}

>  		err = request_irq(info->gpmc_irq_fifo,	omap_nand_irq,

>

Comments

Tony Lindgren Sept. 11, 2012, 5:42 a.m.
* Mohammed, Afzal <afzal@ti.com> [120910 22:36]:
> Hi Tony,
> 
> On Tue, Sep 11, 2012 at 05:47:10, Tony Lindgren wrote:
> 
> > FYI, looks like a new warning got introduced, so I've
> > committed the following trivial patch on top of this series.
> 
> I was not careful enough, sorry. Thanks for fixing it.
> 
> Another hunk as follows would also be required for error
> path even though compiler didn't complain.
> 
> Not sure whether you can fixup or I should post as a
> separate patch.

Oh OK, please just post a separate patch as I've
already pushed it out.

> As an aside, there was compiler warning before this
> series, but I didn't dare to touch it, so a warning
> was seen but thought it was due to the earlier one.
> And now Arnd has fixed the original warning.

OK

Regards,

Tony
Mohammed Afzal Sept. 11, 2012, 6:40 a.m.
Hi Tony,

On Tue, Sep 11, 2012 at 11:12:27, Tony Lindgren wrote:
> * Mohammed, Afzal <afzal@ti.com> [120910 22:36]:

> > I was not careful enough, sorry. Thanks for fixing it.
> > 
> > Another hunk as follows would also be required for error
> > path even though compiler didn't complain.
> > 
> > Not sure whether you can fixup or I should post as a
> > separate patch.
> 
> Oh OK, please just post a separate patch as I've
> already pushed it out.

I have posted a separate patch, please consider for
inclusion in your tree.

BTW, you original commit that fixes the compiler
warning has some strange characters.

Regards
Afzal
Tony Lindgren Sept. 11, 2012, 6:21 p.m.
* Mohammed, Afzal <afzal@ti.com> [120910 23:40]:
> Hi Tony,
> 
> On Tue, Sep 11, 2012 at 11:12:27, Tony Lindgren wrote:
> > * Mohammed, Afzal <afzal@ti.com> [120910 22:36]:
> 
> > > I was not careful enough, sorry. Thanks for fixing it.
> > > 
> > > Another hunk as follows would also be required for error
> > > path even though compiler didn't complain.
> > > 
> > > Not sure whether you can fixup or I should post as a
> > > separate patch.
> > 
> > Oh OK, please just post a separate patch as I've
> > already pushed it out.
> 
> I have posted a separate patch, please consider for
> inclusion in your tree.
> 
> BTW, you original commit that fixes the compiler
> warning has some strange characters.

Ah thanks, that's a copy paste UTF-8 issue. I'll just fold
in the fixes and push them out to a new devel-gpmc-fixed
branch.

Regards,

Tony
Mohammed Afzal Sept. 12, 2012, 9:21 a.m.
On Tue, Sep 11, 2012 at 23:51:07, Tony Lindgren wrote:

> Ah thanks, that's a copy paste UTF-8 issue. I'll just fold
> in the fixes and push them out to a new devel-gpmc-fixed
> branch.

Thanks Tony

Regards
Afzal

Patch hide | download patch | download mbox

diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 337cf0a..27293e3 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -1404,6 +1404,7 @@  static int __devinit omap_nand_probe(struct platform_device *pdev)
                info->gpmc_irq_count = platform_get_irq(pdev, 1);
                if (info->gpmc_irq_count <= 0) {
                        dev_err(&pdev->dev, "error getting count irq\n");
+                       err = -ENODEV;
                        goto out_release_mem_region;
                }
                err = request_irq(info->gpmc_irq_count, omap_nand_irq,