diff mbox

Further OpenBSD/amd64 and OpenBSD/i386 improvements

Message ID alpine.LNX.2.00.1209092356400.4718@trevally.site
State New
Headers show

Commit Message

Gerald Pfeifer Sept. 9, 2012, 10:04 p.m. UTC 
Hi Mark,

On Tue, 4 Sep 2012, Mark Kettenis wrote:
> Here are some additional fixes for OpenBSD that fix a fair number of
> failing testcases.  I can split this up in smaller patches if that's
> preferred.

in general having one patch per issue is preferred, and it makes it
easier and quicker to get things reviewed.

Also, can you note how you tested things as part of patch submission?

For example, "tested on i386-unknown-openbsd83.2 without regressions",
and ideally submitting those results to gcc-testresults@gcc.gnu.org
via $GCC_SOURCE/contrib/test_summary.

(Ideally, a before/after test submitted there will nicely reflect the
improvements your patch provides.  For some FreeBSD targets I am running
a nightly tester, and run special one-off tests in between for patches.
All these appear on gcc-testresults.)

> I believe I submitted the openbsd-stdint.h bit before.  We consistenly
> use "long long" types for the *max_t types, on both 32-bit and 64-bit
> platforms wheras GCC defaults to using "long" on 32-bit platforms and
> "long long" on 64-bit platforms.  Hence the need for overrides.

Yes, you did.  I went ahead an applied this per the patch below,
since by definition it can only affect OpenBSD is looks straighforward.

Gerald


2012-09-09  Mark Kettenis  <kettenis@gnu.org>

	* config/openbsd-stdint.h (INTMAX_TYPE, UINTMAX_TYPE): Define.
diff mbox

Patch

Index: config/openbsd-stdint.h
===================================================================
--- config/openbsd-stdint.h	(revision 191119)
+++ config/openbsd-stdint.h	(working copy)
@@ -26,6 +26,9 @@ 
 #define UINT_FAST16_TYPE	"unsigned int"
 #define UINT_FAST32_TYPE	"unsigned int"
 #define UINT_FAST64_TYPE	"long long unsigned int"
+
+#define INTMAX_TYPE		"long long int"
+#define UINTMAX_TYPE		"long long unsigned int"
  
 #define INTPTR_TYPE		"long int"
 #define UINTPTR_TYPE		"long unsigned int"