From patchwork Sat Sep 8 20:56:36 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Edelsohn X-Patchwork-Id: 182591 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id D3DE82C0093 for ; Sun, 9 Sep 2012 06:56:54 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1347742615; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:Received:Date:Message-ID:Subject:From:To: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=+IkIqxA K6FCwEeSodqBnTVp7DFY=; b=IEb8cmiigdmrZdpl9n7lxjiI8f68IDFiN1VPHq6 R2MbtextHqzyNyxDQrhk7jworg8ViubcAQMs6be2O4dOuqvvJcDB7OMrzMk+KaWP ubwVOSV1IPQ8NyljB0WoE5r0KllIR2lKMIPjejh/vPFl7t8FnBTvUJNrlWTzr5QF sjcs= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:MIME-Version:Received:Received:Date:Message-ID:Subject:From:To:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=X7sjlYnuaGb2GXDvdc0A9qLyia3ws9LApsQP29LLyUPnbRRUys5/xClhKaX8FH BkMyXZYaNtAzuSLfssH9u0D2d0dFUDCBwHBIAGzX02AVuuKdzAZuQAOiUYrH2pYg FLBwOfruuW2NhwBELQHKPTys+kOtpP4dgA23EsKf5cvtI=; Received: (qmail 25649 invoked by alias); 8 Sep 2012 20:56:51 -0000 Received: (qmail 25639 invoked by uid 22791); 8 Sep 2012 20:56:50 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, TW_IB X-Spam-Check-By: sourceware.org Received: from mail-vb0-f47.google.com (HELO mail-vb0-f47.google.com) (209.85.212.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 08 Sep 2012 20:56:36 +0000 Received: by vbbez10 with SMTP id ez10so1219031vbb.20 for ; Sat, 08 Sep 2012 13:56:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.92.98 with SMTP id cl2mr10082591vdb.101.1347137796102; Sat, 08 Sep 2012 13:56:36 -0700 (PDT) Received: by 10.58.14.211 with HTTP; Sat, 8 Sep 2012 13:56:36 -0700 (PDT) Date: Sat, 8 Sep 2012 16:56:36 -0400 Message-ID: Subject: Ping: [PATCH] top-level libtool / configure.ac PIC support for AIX From: David Edelsohn To: GCC Patches , DJ Delorie Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org As mentioned in http://gcc.gnu.org/ml/gcc-patches/2012-08/msg01364.html GCC now is performing optimizations in binds_local_p() that necessitates adding -fPIC when compiling objects for shared libraries on AIX. The libtool patch has been accepted upstream. -fPIC creates unique names for some weak symbols, causing spurious miscompares addressed by the patch to top-level configure.ac. The libquadmath patch is another patch waiting for approval. How do the requirements to regenerate configure interact with the shared, top-level directories? The only strange difference I saw in GCC was the libatomic subdirectory, which had differences for AMTAR although the same version of autoconf. Bootstrapped and regression tested on powerpc-ibm-aix5.3.0.0 and powerpc-ibm-aix7.1.0.0. Thanks, David Merge upstream change. * libtool.m4 (_LT_COMPILER_PIC): Add -fPIC to GCC and GXX for AIX. * configure.ac: Add target-libquadmath to noconfigdirs for AIX. Add libgomp*.o to compare_exclusions for AIX. * configure: Regenerate * */configure: Regenerate AC_SUBST(compare_exclusions) Index: libtool.m4 =================================================================== --- libtool.m4 (revision 191073) +++ libtool.m4 (working copy) @@ -3580,6 +3580,7 @@ # AIX 5 now supports IA64 processor _LT_TAGVAR(lt_prog_compiler_static, $1)='-Bstatic' fi + _LT_TAGVAR(lt_prog_compiler_pic, $1)='-fPIC' ;; amigaos*) @@ -3891,6 +3892,7 @@ # AIX 5 now supports IA64 processor _LT_TAGVAR(lt_prog_compiler_static, $1)='-Bstatic' fi + _LT_TAGVAR(lt_prog_compiler_pic, $1)='-fPIC' ;; amigaos*) Index: configure.ac =================================================================== --- configure.ac (revision 191073) +++ configure.ac (working copy) @@ -527,6 +527,15 @@ fi fi +# Disable libquadmath for some systems. +case "${target}" in + # libquadmath is unused on AIX and libquadmath build process use of + # LD_LIBRARY_PATH can break AIX bootstrap. + powerpc-*-aix* | rs6000-*-aix*) + noconfigdirs="$noconfigdirs target-libquadmath" + ;; +esac + # Disable libssp for some systems. case "${target}" in avr-*-*) @@ -3187,6 +3196,7 @@ case "$target" in hppa*64*-*-hpux*) ;; hppa*-*-hpux*) compare_exclusions="gcc/cc*-checksum\$(objext) | */libgcc/lib\ 2funcs* | gcc/ada/*tools/*" ;; + powerpc*-ibm-aix*) compare_exclusions="gcc/cc*-checksum\$(objext) | gcc/ada/\ *tools/* | *libgomp*\$(objext)" ;; esac