Patchwork [1/4] If linux-pam is built, enable dbm functionality in Berkeley DB

login
register
mail settings
Submitter Dimitry Golubovsky
Date Sept. 8, 2012, 4:21 a.m.
Message ID <1347078066-25257-1-git-send-email-golubovsky@gmail.com>
Download mbox | patch
Permalink /patch/182497/
State Rejected
Headers show

Comments

Dimitry Golubovsky - Sept. 8, 2012, 4:21 a.m.
The linux-pam library has the pam_userdb module which uses a
dbm-compatible database to authenticate users. Berkeley DB provides
such functionality, so it has to be condidionally enabled if linux-pam
is used.

Signed-off-by: Dmitry <golubovsky@gmail.com>
---
 package/berkeleydb/berkeleydb.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Thomas Petazzoni - Sept. 11, 2012, 2:32 p.m.
Le Sat,  8 Sep 2012 00:21:03 -0400,
Dmitry <golubovsky@gmail.com> a écrit :

> +		$(if $(BR2_PACKAGE_LINUX_PAM),--enable-dbm,--disable-dbm) \

I don't really like this. I think you should rather add a configuration
sub-option in package/berkeleydb/Config.in to enable/disable DBM
support, and then have berkeleydb.mk test this configuration option,
and the linux-pam/Config.in package select it.

I don't like when one package recipe pokes into the configuration
options of another package.

Best regards,

Thomas
Dimitry Golubovsky - Sept. 11, 2012, 2:46 p.m.
Thomas,

On Tue, Sep 11, 2012 at 10:32 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Le Sat,  8 Sep 2012 00:21:03 -0400,
> Dmitry <golubovsky@gmail.com> a écrit :
>
>> +             $(if $(BR2_PACKAGE_LINUX_PAM),--enable-dbm,--disable-dbm) \
>
> I don't really like this. I think you should rather add a configuration
> sub-option in package/berkeleydb/Config.in to enable/disable DBM
> support, and then have berkeleydb.mk test this configuration option,
> and the linux-pam/Config.in package select it.

Well, adding extra config options is what I really wanted to avoid.
But this may be just my way of thinking.

> I don't like when one package recipe pokes into the configuration
> options of another package.

It is not a problem to add such configuration item, I'll do it.

Thanks.

Patch

diff --git a/package/berkeleydb/berkeleydb.mk b/package/berkeleydb/berkeleydb.mk
index 3037da6..3ca334f 100644
--- a/package/berkeleydb/berkeleydb.mk
+++ b/package/berkeleydb/berkeleydb.mk
@@ -30,6 +30,7 @@  define BERKELEYDB_CONFIGURE_CMDS
 		$(if $(BR2_INSTALL_LIBSTDCPP),--enable-cxx,--disable-cxx) \
 		--disable-java \
 		--disable-tcl \
+		$(if $(BR2_PACKAGE_LINUX_PAM),--enable-dbm,--disable-dbm) \
 		--disable-compat185 \
 		$(SHARED_STATIC_LIBS_OPTS) \
 		--with-pic \