Patchwork fix gcc.dg/tm/reg-promotion.c

login
register
mail settings
Submitter Aldy Hernandez
Date Sept. 7, 2012, 6:20 p.m.
Message ID <504A3AEB.6090605@redhat.com>
Download mbox | patch
Permalink /patch/182432/
State New
Headers show

Comments

Aldy Hernandez - Sept. 7, 2012, 6:20 p.m.
This is a bit different, in that we don't currently have an 
infrastructure to test transactional memory code within the 
simulate-thread framework.  Luckily for this test, the LIM pass has an 
actual dump message when it fails to hoist a value due to its presence 
in a transaction.

Eventually/ideally, we should have a mechanism for testing races of 
transactionally executed code.

OK?
testsuite/
	* gcc.dg/tm/reg-promotion.c: Modify dump message check.
Richard Guenther - Sept. 10, 2012, 9:37 a.m.
On Fri, Sep 7, 2012 at 8:20 PM, Aldy Hernandez <aldyh@redhat.com> wrote:
> This is a bit different, in that we don't currently have an infrastructure
> to test transactional memory code within the simulate-thread framework.
> Luckily for this test, the LIM pass has an actual dump message when it fails
> to hoist a value due to its presence in a transaction.
>
> Eventually/ideally, we should have a mechanism for testing races of
> transactionally executed code.
>
> OK?

Ok.

Thanks,
Richard.

Patch

diff --git a/gcc/testsuite/gcc.dg/tm/reg-promotion.c b/gcc/testsuite/gcc.dg/tm/reg-promotion.c
index 337c29f..e48bfb2 100644
--- a/gcc/testsuite/gcc.dg/tm/reg-promotion.c
+++ b/gcc/testsuite/gcc.dg/tm/reg-promotion.c
@@ -20,5 +20,5 @@  void func()
   }
 }
 
-/* { dg-final { scan-tree-dump-times "MEM count_lsm.. count_lsm_flag" 1 "lim1" } } */
+/* { dg-final { scan-tree-dump-times "Cannot hoist conditional load of count because it is in a transaction" 1 "lim1" } } */
 /* { dg-final { cleanup-tree-dump "lim1" } } */