Patchwork [2/2] extensions: libxt_addrtype: fix type in help message

login
register
mail settings
Submitter Pablo Neira
Date Sept. 7, 2012, 8:55 a.m.
Message ID <1347008119-3835-2-git-send-email-pablo@netfilter.org>
Download mbox | patch
Permalink /patch/182345/
State Accepted
Headers show

Comments

Pablo Neira - Sept. 7, 2012, 8:55 a.m.
From: Pablo Neira Ayuso <pablo@netfilter.org>

 --limit-iface-out          Match only on the packet's incoming device

Note that it says "incoming" when it should say "outcoming"

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 extensions/libxt_addrtype.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Jan Engelhardt - Sept. 7, 2012, 3:01 p.m.
On Friday 2012-09-07 10:55, pablo@netfilter.org wrote:

>From: Pablo Neira Ayuso <pablo@netfilter.org>
>
> --limit-iface-out          Match only on the packet's incoming device
>
>Note that it says "incoming" when it should say "outcoming"

Language time! :D

"to come" is a movement of an object into the direction of the 
speaker/viewer, "to go" the movement away from the viewer.

Since iptables as a viewer is always at the machine, "outgoing" is the 
term that is being used.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pablo Neira - Sept. 7, 2012, 4:20 p.m.
On Fri, Sep 07, 2012 at 05:01:44PM +0200, Jan Engelhardt wrote:
> On Friday 2012-09-07 10:55, pablo@netfilter.org wrote:
> 
> >From: Pablo Neira Ayuso <pablo@netfilter.org>
> >
> > --limit-iface-out          Match only on the packet's incoming device
> >
> >Note that it says "incoming" when it should say "outcoming"
> 
> Language time! :D
> 
> "to come" is a movement of an object into the direction of the 
> speaker/viewer, "to go" the movement away from the viewer.
> 
> Since iptables as a viewer is always at the machine, "outgoing" is the 
> term that is being used.

You're quite right :-), while writing it with my Spanish mind it
looked to me quite reasonable.

Of course, it's not. I'll fix it, thanks Jan.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/extensions/libxt_addrtype.c b/extensions/libxt_addrtype.c
index 59072b3..d57865b 100644
--- a/extensions/libxt_addrtype.c
+++ b/extensions/libxt_addrtype.c
@@ -60,7 +60,7 @@  static void addrtype_help_v1(void)
 " [!] --src-type type[,...]      Match source address type\n"
 " [!] --dst-type type[,...]      Match destination address type\n"
 "     --limit-iface-in           Match only on the packet's incoming device\n"
-"     --limit-iface-out          Match only on the packet's incoming device\n"
+"     --limit-iface-out          Match only on the packet's outcoming device\n"
 "\n"
 "Valid types:           \n");
 	addrtype_help_types();