From patchwork Fri Sep 7 08:55:18 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pablo Neira Ayuso X-Patchwork-Id: 182344 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 876702C008C for ; Fri, 7 Sep 2012 18:56:30 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754522Ab2IGI42 (ORCPT ); Fri, 7 Sep 2012 04:56:28 -0400 Received: from mail.us.es ([193.147.175.20]:50178 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753066Ab2IGI42 (ORCPT ); Fri, 7 Sep 2012 04:56:28 -0400 Received: (qmail 2849 invoked from network); 7 Sep 2012 10:56:26 +0200 Received: from unknown (HELO us.es) (192.168.2.12) by us.es with SMTP; 7 Sep 2012 10:56:26 +0200 Received: (qmail 27418 invoked by uid 507); 7 Sep 2012 08:56:25 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on antivirus2 X-Spam-Level: X-Spam-Status: No, score=-96.4 required=7.5 tests=BAYES_50, RCVD_IN_BRBL_LASTEXT,RCVD_IN_PBL,RCVD_IN_RP_RNBL,RCVD_IN_SORBS_DUL, RDNS_DYNAMIC,USER_IN_WHITELIST autolearn=disabled version=3.3.1 Received: from 127.0.0.1 by antivirus2 (envelope-from , uid 501) with qmail-scanner-2.08 (clamdscan: 0.97.5/15323. Clear:RC:1(127.0.0.1):. Processed in 0.025769 secs); 07 Sep 2012 08:56:25 -0000 Received: from unknown (HELO antivirus2) (127.0.0.1) by us.es with SMTP; 7 Sep 2012 08:56:25 -0000 Received: from 192.168.1.13 (192.168.1.13) by antivirus2 (F-Secure/fsigk_smtp/407/antivirus2); Fri, 07 Sep 2012 10:56:25 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/407/antivirus2) Received: (qmail 2036 invoked from network); 7 Sep 2012 10:56:25 +0200 Received: from 202.95.221.87.dynamic.jazztel.es (HELO localhost.localdomain) (pneira@us.es@87.221.95.202) by us.es with SMTP; 7 Sep 2012 10:56:25 +0200 From: pablo@netfilter.org To: netfilter-devel@vger.kernel.org Subject: [PATCH 1/2] iptables: fix wrong error messages Date: Fri, 7 Sep 2012 10:55:18 +0200 Message-Id: <1347008119-3835-1-git-send-email-pablo@netfilter.org> X-Mailer: git-send-email 1.7.10.4 Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org From: Pablo Neira Ayuso iptables -P INPUT iptables v1.4.15: -X requires a chain and a policy Try `iptables -h' or 'iptables --help' for more information. Note that it says -X when we have used -P. Signed-off-by: Pablo Neira Ayuso --- iptables/ip6tables.c | 2 +- iptables/iptables.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/iptables/ip6tables.c b/iptables/ip6tables.c index b191d5d..7a16b97 100644 --- a/iptables/ip6tables.c +++ b/iptables/ip6tables.c @@ -85,7 +85,7 @@ #define CMD_CHECK 0x4000U #define NUMBER_OF_CMD 16 static const char cmdflags[] = { 'I', 'D', 'D', 'R', 'A', 'L', 'F', 'Z', - 'Z', 'N', 'X', 'P', 'E', 'S', 'C' }; + 'N', 'X', 'P', 'E', 'S', 'Z', 'C' }; #define NUMBER_OF_OPT ARRAY_SIZE(optflags) static const char optflags[] diff --git a/iptables/iptables.c b/iptables/iptables.c index 03ac63b..9e3d696 100644 --- a/iptables/iptables.c +++ b/iptables/iptables.c @@ -81,7 +81,7 @@ #define CMD_CHECK 0x4000U #define NUMBER_OF_CMD 16 static const char cmdflags[] = { 'I', 'D', 'D', 'R', 'A', 'L', 'F', 'Z', - 'Z', 'N', 'X', 'P', 'E', 'S', 'C' }; + 'N', 'X', 'P', 'E', 'S', 'Z', 'C' }; #define OPT_FRAGMENT 0x00800U #define NUMBER_OF_OPT ARRAY_SIZE(optflags)