Patchwork [U-Boot] mpc85xx: make gpio_direction_output respect value

login
register
mail settings
Submitter Chris Packham
Date Sept. 7, 2012, 3:28 a.m.
Message ID <1346988515-16849-1-git-send-email-judge.packham@gmail.com>
Download mbox | patch
Permalink /patch/182307/
State Accepted, archived
Delegated to: Andy Fleming
Headers show

Comments

Chris Packham - Sept. 7, 2012, 3:28 a.m.
From: Chris Packham <chris.packham@alliedtelesis.co.nz>

Users of familiar with the Linux gpiolib API expect that value parameter
to gpio_direction_output reflects the initial state of the output pin.
gpio_direction_output was always driving the output low, now it drives
it high or low according to the value provided.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: Kyle Moffett <Kyle.D.Moffett@boeing.com>
Cc: Andy Fleming <afleming@gmail.com>
Cc: Peter Tyser <ptyser@xes-inc.com>
Cc: Kumar Gala <galak@kernel.crashing.org>
---
 arch/powerpc/include/asm/mpc85xx_gpio.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Patch

diff --git a/arch/powerpc/include/asm/mpc85xx_gpio.h b/arch/powerpc/include/asm/mpc85xx_gpio.h
index 5a608a5..2aed514 100644
--- a/arch/powerpc/include/asm/mpc85xx_gpio.h
+++ b/arch/powerpc/include/asm/mpc85xx_gpio.h
@@ -98,7 +98,10 @@  static inline int gpio_direction_input(unsigned gpio)
 
 static inline int gpio_direction_output(unsigned gpio, int value)
 {
-	mpc85xx_gpio_set_low(1U << gpio);
+	if (value)
+		mpc85xx_gpio_set_high(1U << gpio);
+	else
+		mpc85xx_gpio_set_low(1U << gpio);
 	return 0;
 }