Patchwork configure: fix seccomp check

login
register
mail settings
Submitter Yann E. MORIN
Date Sept. 6, 2012, 8:40 p.m.
Message ID <1346964030-17633-1-git-send-email-yann.morin.1998@free.fr>
Download mbox | patch
Permalink /patch/182278/
State New
Headers show

Comments

Yann E. MORIN - Sept. 6, 2012, 8:40 p.m.
Currently, if libseccomp is missing but the user explicitly requested
seccomp support using --enable-seccomp, configure silently ignores the
situation and disables seccomp support.

This is unlike all other tests that explicitly fail in such situation.

Fix that.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 configure |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Andreas Färber - Sept. 7, 2012, 2:41 p.m.
Am 06.09.2012 22:40, schrieb Yann E. MORIN:
> Currently, if libseccomp is missing but the user explicitly requested
> seccomp support using --enable-seccomp, configure silently ignores the
> situation and disables seccomp support.
> 
> This is unlike all other tests that explicitly fail in such situation.
> 
> Fix that.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Reviewed-by: Andreas Färber <afaerber@suse.de>

Andreas
Stefan Hajnoczi - Sept. 14, 2012, 7:46 a.m.
On Thu, Sep 06, 2012 at 10:40:30PM +0200, Yann E. MORIN wrote:
> Currently, if libseccomp is missing but the user explicitly requested
> seccomp support using --enable-seccomp, configure silently ignores the
> situation and disables seccomp support.
> 
> This is unlike all other tests that explicitly fail in such situation.
> 
> Fix that.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  configure |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Patch

diff --git a/configure b/configure
index c5888fa..23abb46 100755
--- a/configure
+++ b/configure
@@ -1429,10 +1429,10 @@  if test "$seccomp" != "no" ; then
         LIBS=`$pkg_config --libs libseccomp`
 	seccomp="yes"
     else
-	seccomp="no"
 	if test "$seccomp" = "yes"; then
             feature_not_found "libseccomp"
 	fi
+	seccomp="no"
     fi
 fi
 ##########################################